[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: more randconfig failures

  • To: Julien Grall <julien.grall.oss@xxxxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Wed, 27 Jan 2021 23:11:09 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BaWx52LeTIkv/MMZiS5UxQA0/CcXRpLo5ow8sNe2Wtw=; b=Jr5KedYjIQwcwmUsH5BgNqMOgvG/zdneiuyLb4nf2LPoFEhyQvnNyQAcLAmDKtbiZLr4sk4nUUAkNZuvGdm7SbMyjrxkcpua8oQCT/rcfRpz2WPqcuyycHeZEo7tfTiBmSph3UKj2AoSWfxwOCMgiHdkTsudwC3JbLcfx0PkfjGY8FyR5X/EAojp0VgexejOZKV59fe8Ge2nMITSBBTwbTzR9aMRtW/ccs2qO8d7wRWMpUjKJ4nxfftEm4mh+VFI8YxsFFWnPaBry/xpbv8SNC3SedG4qoz0lAmvNONPrUQCsSnqeX2PwCW41DTvWZnDb7n39Pm2LQrt4rNalAT0Xw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j8sG65AcmRdnaAZz2rnHbZyucK8iD9VMF20l/+CZMZlki5wMHmmtWI0KOjEPQbIbfE9XPVzluKJF96ekiem1zvBG9QNjXdaVecWquAa4LzVl5mWY9o9nP5/086p9JVGHrKHcmYPc6VDVGZ78s/+uf1HLLHCegXHBXmf3EQzxsGA9hGdgdWyxOBG/iUmWZdPQV8LylLcfHnf0SZ00pbwwtv9Ggaw7rTJDJv4yfte6AftW8Ek3E8z37iGdyPqOM9z2kG6W0ZAReAxBzTAYdNzU7aFKkuEifTERVJK0aocjYyKUEeXIwMZBzS2OMoNSVhxsWtbyUA3kjn6LtI+CsI2wog==
  • Authentication-results-original: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, "fam@xxxxxxxxxx" <fam@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "famzheng@xxxxxxxxxx" <famzheng@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 27 Jan 2021 23:11:34 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHW9PHL4o4H3Jgv2EydpBL/6Ktl0ao7+9gAgAAdpwA=
  • Thread-topic: more randconfig failures

Hello Julien,

> On 27 Jan 2021, at 9:25 pm, Julien Grall <julien.grall.oss@xxxxxxxxx> wrote:
> Hi,
> On Wed, 27 Jan 2021 at 21:16, Stefano Stabellini <sstabellini@xxxxxxxxxx> 
> wrote:
>> Hi all,
>> These are two recent randconfig build failures reported by gitlab (the
>> two patches that triggered the CI-loop are two patches to the
>> MAINTAINERS file -- certainly not the cause of the build issues):
>> x86 randconfig failure:
>> https://gitlab.com/xen-project/patchew/xen/-/jobs/990347647
>> arm randconfig failure:
>> https://gitlab.com/xen-project/patchew/xen/-/jobs/990335472
> make[5]: Leaving directory '/builds/xen-project/patchew/xen/xen/common/libfdt'
> smmu-v3.c: In function 'acpi_smmu_get_options':
> smmu-v3.c:3017:7: error: 'ACPI_IORT_SMMU_V3_CAVIUM_CN99XX' undeclared
> (first use in this function)
> 3017 |  case ACPI_IORT_SMMU_V3_CAVIUM_CN99XX:
>      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> smmu-v3.c:3017:7: note: each undeclared identifier is reported only
> once for each function it appears in
> smmu-v3.c:3020:7: error: 'ACPI_IORT_SMMU_V3_HISILICON_HI161X'
> undeclared (first use in this function)
> 3020 |  case ACPI_IORT_SMMU_V3_HISILICON_HI161X:
>      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  INIT_O  efi-dom0.init.o
> smmu-v3.c: In function 'arm_smmu_device_acpi_probe':
> smmu-v3.c:3035:36: error: implicit declaration of function
> 'dev_get_platdata' [-Werror=implicit-function-declaration]
> 3035 |  node = *(struct acpi_iort_node **)dev_get_platdata(dev);
>      |                                    ^~~~~~~~~~~~~~~~
> smmu-v3.c:3035:36: error: nested extern declaration of
> 'dev_get_platdata' [-Werror=nested-externs]
> smmu-v3.c:3035:10: error: cast to pointer from integer of different
> size [-Werror=int-to-pointer-cast]
> 3035 |  node = *(struct acpi_iort_node **)dev_get_platdata(dev);
>      |          ^
> ld    -EL  -r -o built_in.o memcpy.o memcmp.o memmove.o memset.o
> memchr.o clear_page.o bitops.o find_next_bit.o strchr.o strcmp.o
> strlen.o strncmp.o strnlen.o strrchr.o
> cc1: all warnings being treated as errors
> It looks like the SMMUv3 driver has not been built tested with
> CONFIG_ACPI=y.  Bertrand, Rahul, can you take a look?

Sorry my mistake I didn’t enable the ARM_SMMU_V3 with ACPI and tested the 

There are two option to fix this:

1. #undef-ining the CONFIG_ACPI in the smmu-v3.c file and fix the compilation. 
In this case once we have ACPI IORT table code ported to XEN smmu-v3 code can 
be used at that time.
2.  Remove the arm_smmu_device_acpi_probe() from the smmu-v3.c now and once we 
have  ACPI IORT table code ported to XEN we can add it back.

Let me know your view I will send the patch to fix the compilation.

> Cheers,



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.