[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH for-4.15] x86/boot: Drop 'noapic' suggestion from check_timer()

  • To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 27 Jan 2021 19:49:04 +0000
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • Delivery-date: Wed, 27 Jan 2021 19:49:46 +0000
  • Ironport-sdr: SsovgsDCPNMSz8lYc36OPvT67G73rZPaghLLiRvDP6zU+YbLMlDy7eHdaoCax5Z1HYuPT5SbQp xlD4U8Ruj9PUMEmQP/HzOumoB9VoPRrkPthwhmcz0nDHZR0hQZJm3KWIRzyC6e00NCTRK4cUiz pnBpPoRTnYmEmOOgf1iOPYuXWX/0oPeFFNKS56Fk2jNu4I9m2021KddTducDF/GQ2SlyFZmB12 0JF1lDs/s0CrkRuZEsNXRbsSEyjXrdCvk3n89TLZZFivVkbpRXt4qNrTYGfXzAPcjSwQfIp7hQ KGw=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

In practice, there is no such thing as a real 64bit system without
APICs.  (PVH style virtual environments, sure, but they don't end up here).

The suggestion to try and use noapic only makes a bad situation worse.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Wei Liu <wl@xxxxxxx>
CC: Ian Jackson <iwj@xxxxxxxxxxxxxx>

I wanted to have enough time to drop all of the pre-APIC infrastructure, but
that is a massive can of decades-old-worms.  For 4.15, suffice just to to
prevent misleading users more than necessary.
 xen/arch/x86/io_apic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c
index e66fa99ec7..e93265f379 100644
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -1994,8 +1994,7 @@ static void __init check_timer(void)
     printk(" failed :(.\n");
-    panic("IO-APIC + timer doesn't work!  Boot with apic_verbosity=debug "
-          "and send a report.  Then try booting with the 'noapic' option\n");
+    panic("IO-APIC + timer doesn't work!  Boot with apic_verbosity=debug and 
send a report\n");



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.