[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] Fix error: array subscript has type 'char' [and 1 more messages]
George Dunlap writes ("Re: [PATCH] Fix error: array subscript has type 'char' [and 1 more messages]"): > > On Jan 27, 2021, at 4:32 PM, Jan Beulich <jbeulich@xxxxxxxx> wrote: > > On 27.01.2021 17:21, Ian Jackson wrote: > >> Are you OK with me checking in the current patch or should I ask the > >> other committers for a second opinion ? > > > > For the changes to tools/ it's really up to you. For the change > > to xen/tools/symbols.c I could live with it (for being user > > space code), but I still think adding casts in such a place is > > not necessarily setting a good precedent. So for this one I'd > > indeed appreciate getting another opinion. > > My thoughts: > > * On the whole, the risk of an incompatibility with system headers does seem > higher than the risk of casting a value which is known not to be EOF > > * Such a change doesn’t seem like the kind of thing we should ask Manuel to > do, when a simpler change will do the trick > > * At any rate it doesn’t seem like a good thing to experiment with in the > week before the feature freeze. Thanks, George. Given the release timing, I intend to commit Manuel's patch unless I hear a further contrary opinion before 1700 UTC tomorrow. NB that with my RM hat on I consider this a bugfix so it would not need a freeze exception to be committed next week but obviously with my RM hat on I would prefer no to delay it. Ian.
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |