[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 08/10] tools/misc: Add xen-vmtrace tool
- To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 26 Jan 2021 12:55:09 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ofQkRP8G45OxjduCSyQew8JrLk/98Ast4e8Diq4WgE=; b=fX+2Xn/JoAR0kcDxR+8N6aj8Wcx1ZgJpHlu6kNDtU5rC0i9o4ee9TIezvgs/QFviAYI+35BwVchpu7jW2P+oHBpFQ2prm+Ggxw1gAUannHQ/r/rTH5ZUKKJxYNKyi3TD9WWZWkhtvMD7z0q9tAlgh7sGQOfYe8IJZ2spzWV17upX+/l/e4SJty+kccjvFp3iTUnpGdl216pe/aJMLy2jwWk7dy79jl1YFy6BBX6+T9/WNhcJ2Q/yOrlT2ubbIi6U23CX2sy3qxhHuoOfqNHdaYX7D0zD6jzur58HYcXf6jl3NdCfEddiU9rDU9fumXsWHjAjRY76lDI3REnY/yi1HA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a/3ebkNinhNiNG2oaL0xk+PQNi132gmyorMsUVoc8U1d34f37f3Qgu0/sGeOm/ndS7R3hUbLyUVQvo/0l5UY7nOO8jeinq4ySMpfZhQ+iwFVoKUkGEHWncxP/AzyFUXlyxknu6vA2tA7tnYnP3wpPgfFPfYpyIERNDcJmdugQYfpxdShlzuHUUXdaOk+kLRdyS8CsPX//MDPRUTu/lOCs0nxCfqKAJGqs+g1M4/doSkwxPG993Bu1StIZsVnAN++HBG4RT+2P3V6hpBvLZRP0Ckk9GDRe49Jgt4B+OjLMwt1u2ab5KUpMj8/i6EwbHgOtGZmMHjK2xUKxIlsBXgV2w==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Michał Leszczyński <michal.leszczynski@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- Delivery-date: Tue, 26 Jan 2021 12:55:26 +0000
- Ironport-sdr: kcLVWp7wnMUXahkBmR6/JVnZINRgZy/GoRthBJQWMQ8EUs8mq9z64QyttVfK4KLajZkslT8sCS IrHYDfFTs9zOneXdm9m/UNZkzHO7npc3IhXA18bhO+LYJ7AqNgKkrkl6AEhFi2/kvNA9+NjbUH bqW56ZNU7rmyPeElgFTVxIwrJz8L3atAWUFZmoPg9y5PUN36n76Sugo87QgnEyX0RtG1pU8NZM eaMwcAwknvWhwtTBLu8bBxQWzdoRPgsoFZdaEiEzeeBUWot/ivQo2n0H8IQ4yQI51dvzHdl75v 56c=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26/01/2021 11:59, Ian Jackson wrote:
>>> Also: at the very least, you need to trap SIGTERM SIGHUP SIGPIPE.
>>>
>>> It would be good to exit with the right signal by re-raising it.
>> This is example code, not a production utility.
> Perhaps the utility could print some kind of health warning about it
> possibly leaving this perf-impacting feature enabled, and how to clean
> up ?
Why? The theoretical fallout here is not conceptually different to
libxl or qemu segfaulting, or any of the myriad other random utilities
we have.
Printing "Warning - this program, just like everything else in the Xen
tree, might in exceptional circumstances segfault and leave the domain
in a weird state" is obvious, and doesn't need stating.
The domain is stuffed. `xl destroy` may or may not make the problem go away.
~Andrew
|
