[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v10 08/11] docs / tools: specify migration v4 to include DOMAIN_CONTEXT


  • To: Paul Durrant <paul@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 25 Jan 2021 19:43:18 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s5w7IgYtWsjM3ac6WFn8IoSIdMtTgSz7Dxq3vKEcNnY=; b=Vms7CNk5icptSM8juOnuYVf/KTbk1T/u9ULZlL4ggI8+Gep6XuP0iL8C+dVcdzGDN2F6AT75xxrG8TM08nushW7eo967dVdfQJFLRX9mZ5LHeg18FXuvv5Jt/Dm+OQNeKyyRp5e/ZtZd4aWmbhoj5Cx5N895tWEX4prIAg0Df5tI+qUX8nX97WnJfAfqyg94/RT8cbxJj6DAw0DjNspKc2M8+mzVcYjU9BZTUyE6Fv0t6txUGRKibdvsLYwS2gB5Cuz85eMCl7WguNg16Vd+fEzgt4/g+76KiDDmEBtAFSd2wKzneE/exjPXJ1dOZXYwplGrCY/4kG90a7gj5rI69A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g6FvI7XOrjESBTZtoZFGtzS0xbO/bj8FFEKU05nI1FQSKkLRM26iI+eQupPTxEYTuNEWfv3ZlERJPdK9oUuOB+8zkTCmyNhoL+IREPxLzRyhkV5rFHQ8gE/sznJzihMP5LaqZb7CvdBVay2ZLLHAzX4GG36A1bLniz3OP7PQsEScppp5dBW6GW+5ZGVNsD+R+k8uHOPTIr7WZCLG2DjSuXpQOR7xelvigweuuUUdKH+ADY0Hm7m0XjGGj/HcC7QsEPDlzq5rIt9mrii5DTCuFs1fP9kyjUtBD5Q2WS5gASjAqGsHwmlQohNPpcRnMlqXBjxoEySTVSF+X2gvottpBA==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Paul Durrant <pdurrant@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 25 Jan 2021 19:43:39 +0000
  • Ironport-sdr: VajkDAUaewYTyg+VqwszBSoETiipO6aRRFQR5Vn/dkItExx29hDk05uG2hL63Isw9j/7FpMU41 Bg+5youIHtmMSDP+9ogchwBwtP4UJqEXKo00sKQ9ZhBwwbVvKfKmOrNPK6vtxbpy6VrV4WG0Jk pA0kIn7Fm6EMv53BMYOKaf+/U63Z7EzgiRDrP9hNg+rwkwMI6EdKFVyABKE69J9wKJdSXVuArG IgvK12CC4EIoFGKBqDG/bXEf/iVgAUC4Xwcc4C0nGekQdjy++9KlZSELCcBq6ACDjOSvn0wHEL bQE=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 08/10/2020 19:57, Paul Durrant wrote:
> diff --git a/docs/specs/libxc-migration-stream.pandoc 
> b/docs/specs/libxc-migration-stream.pandoc
> index 8aeab3b11b..aa6fe284f3 100644
> --- a/docs/specs/libxc-migration-stream.pandoc
> +++ b/docs/specs/libxc-migration-stream.pandoc
> @@ -127,7 +127,7 @@ marker      0xFFFFFFFFFFFFFFFF.
>  
>  id          0x58454E46 ("XENF" in ASCII).
>  
> -version     0x00000003.  The version of this specification.
> +version     0x00000004.  The version of this specification.
>  
>  options     bit 0: Endianness.  0 = little-endian, 1 = big-endian.
>  
> @@ -209,9 +209,9 @@ type         0x00000000: END
>  
>               0x00000006: X86_PV_VCPU_XSAVE
>  
> -             0x00000007: SHARED_INFO
> +             0x00000007: SHARED_INFO (deprecated)

"in v4" ?

> @@ -442,10 +444,11 @@ X86_PV_VCPU_MSRS             
> XEN_DOMCTL_{get,set}\_vcpu_msrs
>  
>  \clearpage
>  
> -SHARED_INFO
> ------------
> +SHARED_INFO (deprecated)
> +------------------------
>  
> -The content of the Shared Info page.
> +The content of the Shared Info page. This is incorporated into the
> +DOMAIN_CONTEXT record as of specification version 4.

This needs to be stricter.  A SHARED_INFO frame must not be present in a
v4 stream.

Absolutely nothing good can come from having the state twice.  Moreover, ...

>  
>       0     1     2     3     4     5     6     7 octet
>      +-------------------------------------------------+
> @@ -462,11 +465,12 @@ shared_info      Contents of the shared info page.  
> This record
>  
>  \clearpage
>  
> -X86_TSC_INFO
> -------------
> +X86_TSC_INFO (deprecated)
> +-------------------------
>  
>  Domain TSC information, as accessed by the
> -XEN_DOMCTL_{get,set}tscinfo hypercall sub-ops.
> +XEN_DOMCTL_{get,set}tscinfo hypercall sub-ops. This is incorporated into the
> +DOMAIN_CONTEXT record as of specification version 4.

... it is actively problematic for this one, as incarnation counts the
number of set_tsc_info() hypercalls.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.