[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1] xl: use proper name for bash_completion file


  • To: Olaf Hering <olaf@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 22 Jan 2021 13:33:47 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CXj8T+kVBe3oToXqDqgWScLsMhyhrCEkRegfCnEsnis=; b=HQUJFtrZFb5AL+o9ykRkttNWa4IyWwU8So113QgrHxcDBRtxokXBJm/DVzCFVJO8h7ArbBAtBDyM2aYtFSOUj9+ADgDol4U6yS3DkHRTVSb/RLsG3mGca3YQ2CJJ+xfe2wascdk1fksfrGAnbDJGG+jEeA9qfs7IxrE9olE2OjQ5Eb/IoW6plcY5G8Iwl1duhIXuvoO2ZEg3UtOyEbOU67mIw0Wj4RqlCzL9/86uVzs49ov84uNGSyY7dw235afCKJ1AbzK8axitOwQHf9Nu8ZzrNjRQ43eQBYy/khixyV9OwxmKAZ5m6uPOOmdImR+Laz3sTKu9z95YVtrMJZ05KQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bl3m3J4Xhtnttv70cfzGsMA2DEizzr3XB1490QTgOxRXy/0dAP/7ymJuUJ48I7O7eav/oPiy0JNTJOG7s8sPjHcV8ecFQQUkpGjXOchcwEHLsmoW0xwjbVbuCpeFgTEJCsSkNj8ktJVG3MRnx1lUVYbaexj9FH29UF6q23lTFab//VB/7/1nq1TV1XTLRSgVXhxxIw8gJFknqYaH/GgpOTrWKmbnRN+YTA/jKBSRG4FjRQ5EtgAkr7zUJgsEA2ol8yHL4aH46mkCA3Hq+aBhi/wVHG/YCIvMpbZeeNkFeY08hrQ5BY4OsJXpszl/K0NjTp3d6gTq8pFRh9BjfSaBdg==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Fri, 22 Jan 2021 13:34:01 +0000
  • Ironport-sdr: nrFguBrswo1N9dB4Y06rN8HrERl4VyPFcGHLa71E8NV+nfkUDJ6y61bDOCy9FcKav8YEHBQKZ6 AJAc/2Oc1sJU+ByDYLxkdX+fB8DkL7T1osbmeORRPOEqNeoLEjlmhnyG+62frZRrDntlVtL51E 2n+ZvJMN2PPSXY5mPRl99t+6h5+xPTYODLb1MhyNdhSZwELA7DAxhcEG2bwA5QFZn++q+BugGY Fshm0RU3w4MkDlgdi6VI5K8iVr5zaJNSb3su5SggHUurKc5Zkg37yJcxYJe5kLVtLTJcAGOWSV gEU=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 20/10/2020 13:39, Olaf Hering wrote:
> Files in the bash-completion dirs should be named like the commands,
> without suffix. Without this change 'xl' will not be recognized as a
> command with completion support if BASH_COMPLETION_DIR is set to
> /usr/share/bash-completion/completions.
>
> Fixes commit 9136a919b19929ecb242ef327053d55d824397df
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

This obviously fell through the cracks, but definitely matches how
systems are typically set up.

> ---
>  tools/xl/Makefile        | 4 ++--
>  tools/xl/bash-completion | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/xl/Makefile b/tools/xl/Makefile
> index bdf67c8464..656b21c7da 100644
> --- a/tools/xl/Makefile
> +++ b/tools/xl/Makefile
> @@ -45,11 +45,11 @@ install: all
>       $(INSTALL_DIR) $(DESTDIR)$(sbindir)
>       $(INSTALL_DIR) $(DESTDIR)$(BASH_COMPLETION_DIR)
>       $(INSTALL_PROG) xl $(DESTDIR)$(sbindir)
> -     $(INSTALL_DATA) bash-completion $(DESTDIR)$(BASH_COMPLETION_DIR)/xl.sh
> +     $(INSTALL_DATA) bash-completion $(DESTDIR)$(BASH_COMPLETION_DIR)/xl
>  
>  .PHONY: uninstall
>  uninstall:
> -     rm -f $(DESTDIR)$(BASH_COMPLETION_DIR)/xl.sh
> +     rm -f $(DESTDIR)$(BASH_COMPLETION_DIR)/xl
>       rm -f $(DESTDIR)$(sbindir)/xl
>  
>  .PHONY: clean
> diff --git a/tools/xl/bash-completion b/tools/xl/bash-completion
> index b7cd6b3992..7c6ed32f88 100644
> --- a/tools/xl/bash-completion
> +++ b/tools/xl/bash-completion
> @@ -1,4 +1,4 @@
> -# Copy this file to /etc/bash_completion.d/xl.sh
> +# Copy this file to /etc/bash_completion.d/xl
>  
>  _xl()
>  {
>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.