[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v3 1/5] xen: add XEN_BUILD_POSIX_TIME
On 22.01.2021 01:51, Bobby Eshleman wrote: > From: Daniel Kiper <daniel.kiper@xxxxxxxxxx> > > POSIX time is required to fill the TimeDateStamp field > in the PE header. > > Use SOURCE_DATE_EPOCH if available, otherwise use > `date +%s` (available on both Linux and FreeBSD). > > Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx> > Signed-off-by: Bobby Eshleman <bobbyeshleman@xxxxxxxxx> Especially with there not being any user of the new item, you will want to at least briefly explain ... > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -11,6 +11,7 @@ export XEN_DOMAIN ?= $(shell ([ -x /bin/dnsdomainname ] > && /bin/dnsdomainname) | > export XEN_BUILD_DATE ?= $(shell LC_ALL=C date) > export XEN_BUILD_TIME ?= $(shell LC_ALL=C date +%T) > export XEN_BUILD_HOST ?= $(shell hostname) > +export XEN_BUILD_POSIX_TIME ?= $(shell echo $${SOURCE_DATE_EPOCH:-$(shell > date +%s)}) ... the use of SOURCE_DATE_EPOCH here when it's not used for XEN_BUILD_TIME (the two could also do with living side by side) and ... > --- a/xen/include/xen/compile.h.in > +++ b/xen/include/xen/compile.h.in > @@ -1,5 +1,6 @@ > #define XEN_COMPILE_DATE "@@date@@" > #define XEN_COMPILE_TIME "@@time@@" > +#define XEN_COMPILE_POSIX_TIME @@posix_time@@ > #define XEN_COMPILE_BY "@@whoami@@" > #define XEN_COMPILE_DOMAIN "@@domain@@" > #define XEN_COMPILE_HOST "@@hostname@@" ... the lack of quotes here when all neighboring items have them. Jan
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |