[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/4] xl: Add support for ignore_msrs option


  • To: Wei Liu <wl@xxxxxxx>
  • From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
  • Date: Thu, 21 Jan 2021 17:43:41 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P/FVKvprEjfnopWgq4JDhlFyf8ThSFEyUZQA4NT5Lvw=; b=BuBvMPZeKO8xEwr0wcmS16p8XKnCNVkNc3AF9lVGORUhgZdFyMYbPHLnKYlVpW32LOUT3lz835VqVOy+9NPZddWSfH0nZ9FRFiurfehQQsuxxbebayWgczbqWu5s9PTGTHIGlxx9qaFIxhl6eov4cLYMnj9/coPZAP8Pw8vDSVIr1qPELAPr/roNDWviJHCGnptcGSUnMtd6JBsM4Ep9iV5uFvWXX8zwRQeLdB5MYEjGui8jyatL3E8cxn34HUdMQNvqlsV0uZrL5i6+0bag3MLicxrnJN6lqiq0GvkIKFdKubX4jBAoH1ixYG6ASGTGby83woR7tuEv4WFBEjehHA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gY7jxbKr1+nn0Lif27fUUHiLaxuhus+/YymUJg7NwqOTXE39xVjcAZx3pzhOknCp8mA2mVaduY8aeTBmxQFLBtsijyFfD4OP7UloVFIQyfqFXNNB9IZliHZ4tYEjY/xaH3QDK9Cg92b0n6zbDsKcoQTL5TgPNq+ew1uBuu590Xa/32c0pbrusYsPfETipzemJwC+eX4YpxSa9UUkKEburkvfuGsuxLggdd/JwvDjYZiEXwInScbWqBApigEdK0whEhc2D28JmfJb5R7WpZ0fgq1qTvN0Rnhry1bOP3d9eJ6vgP+XIY0txkxY5vCzqG1g70LTBopPe8X4eDtjmFgOWA==
  • Authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=oracle.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, iwj@xxxxxxxxxxxxxx, anthony.perard@xxxxxxxxxx, jbeulich@xxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, jun.nakajima@xxxxxxxxx, kevin.tian@xxxxxxxxx
  • Delivery-date: Thu, 21 Jan 2021 22:45:58 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 1/21/21 9:56 AM, Wei Liu wrote:
> On Wed, Jan 20, 2021 at 05:49:09PM -0500, Boris Ostrovsky wrote:
>> This option allows guest administrator specify what should happen when
>> guest accesses an MSR which is not explicitly emulated by the hypervisor.
>>
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>> ---
>>  docs/man/xl.cfg.5.pod.in         | 20 +++++++++++++++++++-
>>  tools/libs/light/libxl_types.idl |  7 +++++++
>>  tools/xl/xl_parse.c              |  7 +++++++
>>  3 files changed, 33 insertions(+), 1 deletion(-)
> 
> It is mainly missing a #define LIBXL_HAVE_XXX in libxl.h.
> 
> Other than that, this patch looks good to me. If you end up resending
> this series, please fix that issue.
> 
> If other patches are all reviewed, you can provide some text to be
> merged into this patch.
> 
> Wei.
> 


Ah yes, I forgot about this.



diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 3433c950f9aa..f249740daf3f 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -1310,6 +1310,13 @@ void libxl_mac_copy(libxl_ctx *ctx, libxl_mac *dst, 
const libxl_mac *src);
  */
 #define LIBXL_HAVE_CREATEINFO_XEND_SUSPEND_EVTCHN_COMPAT
 
+/*
+ *  LIBXL_HAVE_IGNORE_MSRS indicates that the libxl_ignore_msrs field is
+ *  present in libxl_domain_build_info. This field describes hypervisor
+ *  behavior on guest accesses to unimplemented MSRs.
+ */
+#define LIBXL_HAVE_IGNORE_MSRS 1
+
 typedef char **libxl_string_list;
 void libxl_string_list_dispose(libxl_string_list *sl);
 int libxl_string_list_length(const libxl_string_list *sl);



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.