Re: [PATCH V4 21/24] xen/ioreq: Make x86's send_invalidate_req() common

[Jan Beulich <jbeulich@xxxxxxxx>]

On 18.01.2021 11:31, Paul Durrant wrote:
>> -----Original Message-----
>> From: Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
>> Oleksandr Tyshchenko
>> Sent: 12 January 2021 21:52
>> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
>> Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>; Jan Beulich 
>> <jbeulich@xxxxxxxx>; Andrew
>> Cooper <andrew.cooper3@xxxxxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>; 
>> Wei Liu <wl@xxxxxxx>;
>> George Dunlap <george.dunlap@xxxxxxxxxx>; Ian Jackson <iwj@xxxxxxxxxxxxxx>; 
>> Julien Grall
>> <julien@xxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Paul Durrant 
>> <paul@xxxxxxx>; Julien
>> Grall <julien.grall@xxxxxxx>
>> Subject: [PATCH V4 21/24] xen/ioreq: Make x86's send_invalidate_req() common
>>
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>>
>> As the IOREQ is a common feature now and we also need to
>> invalidate qemu/demu mapcache on Arm when the required condition
>> occurs this patch moves this function to the common code
>> (and remames it to ioreq_signal_mapcache_invalidate).
>> This patch also moves per-domain qemu_mapcache_invalidate
>> variable out of the arch sub-struct (and drops "qemu" prefix).
>>
>> We don't put this variable inside the #ifdef CONFIG_IOREQ_SERVER
>> at the end of struct domain, but in the hole next to the group
>> of 5 bools further up which is more efficient.
>>
>> The subsequent patch will add mapcache invalidation handling on Arm.
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>> CC: Julien Grall <julien.grall@xxxxxxx>
>> [On Arm only]
>> Tested-by: Wei Chen <Wei.Chen@xxxxxxx>
> 
> Reviewed-by: Paul Durrant <paul@xxxxxxx>

Applicable parts
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan