[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 08/10] xen/arm: smmuv3: Use fallthrough pseudo-keyword


  • To: Rahul Singh <Rahul.Singh@xxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Wed, 20 Jan 2021 15:36:17 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bk5tF/uBLTpVBXQPB7cnu9Fm6ekcECdlIiJME0S1ask=; b=KbcKIYbKOZLSsWP8D/kSyIPlsA7exzAPq2Pvb0TygrKIsRm6JKqm9zjRPItfkakUniypZh31RArJ/P7JcVGcTuKvvKqj306wBSZ6JkM97zkzKzEhEC5/QZRfrd/vheYxe3XmjYRFTWyVS0DHRQPMAb7YLaHjrmhMV2iFO+kxTyfX/LMkC22QUBypIJCukMWq+ov5dtbuZbU8OS7i2M/Ga3m8HteebCfUlMp1wBsSvhfXdG9t76kORThVYQt76hDi932pAVjasAkMaXk+t7/0moa0YfM5iL0eLp0MEYvJyX5FUDDI/WEXFhADbziACgrhxHmUaehSk0dHeboHtrsdeg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L0mNItDAqkjIFjGDBaDJ3gRrHCHOE4UY5uwctD9/QePJqbgzju4DM2Iyr6gDsO/PBtV36E6HBOtMe5SCTV0G5+SNL/5KswfLSwNZgjBCQM13qnln6ZNTFd2xa+WMI1HjmUW023Yi5XPwYyEldRVRSDgnAVcVovbqk7z5BORkm3Srj1gqAnDl+5qZpZisgtby9cp/js3Fce1YhLVDyXxUNkhRs3n83P7G4Yh1Bpwop40FA1xezX/mOyRm2cA4FEwP6UEkCDRZmNL8X6IVbRuRplVsHp8MNwoYv16bS7ATbchTgUkzN96mMkMJyR3X2wOMSY0GQJUTxjgC7ZJPuNKySg==
  • Authentication-results-original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Wed, 20 Jan 2021 15:36:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHW7zzqrrhlnhkgj0uR383CHkuypqowpYKA
  • Thread-topic: [PATCH v5 08/10] xen/arm: smmuv3: Use fallthrough pseudo-keyword

Hi Rahul,


> On 20 Jan 2021, at 14:52, Rahul Singh <Rahul.Singh@xxxxxxx> wrote:
> 
> Backport commit df561f6688fef775baa341a0f5d960becd248b11
> "treewide: Use fallthrough pseudo-keyword" from Linux kernel.
> 
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> fall-through markings when it is the case.
> 
> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Cheers
Bertrand

> ---
> Changes since v3:
> - This patch is introduce in this version.
> Changes since v4:
> - Add more information about the merged patch in commit message.
> ---
> ---
> xen/drivers/passthrough/arm/smmu-v3.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/drivers/passthrough/arm/smmu-v3.c 
> b/xen/drivers/passthrough/arm/smmu-v3.c
> index 5ce14850b4..f5f8b4c981 100644
> --- a/xen/drivers/passthrough/arm/smmu-v3.c
> +++ b/xen/drivers/passthrough/arm/smmu-v3.c
> @@ -932,7 +932,6 @@ static void arm_smmu_cmdq_skip_err(struct arm_smmu_device 
> *smmu)
>                */
>               return;
>       case CMDQ_ERR_CERROR_ILL_IDX:
> -             /* Fallthrough */
>       default:
>               break;
>       }
> @@ -2488,7 +2487,7 @@ static int arm_smmu_device_hw_probe(struct 
> arm_smmu_device *smmu)
>       switch (FIELD_GET(IDR0_STALL_MODEL, reg)) {
>       case IDR0_STALL_MODEL_FORCE:
>               smmu->features |= ARM_SMMU_FEAT_STALL_FORCE;
> -             /* Fallthrough */
> +             fallthrough;
>       case IDR0_STALL_MODEL_STALL:
>               smmu->features |= ARM_SMMU_FEAT_STALLS;
>       }
> @@ -2505,7 +2504,7 @@ static int arm_smmu_device_hw_probe(struct 
> arm_smmu_device *smmu)
>       switch (FIELD_GET(IDR0_TTF, reg)) {
>       case IDR0_TTF_AARCH32_64:
>               smmu->ias = 40;
> -             /* Fallthrough */
> +             fallthrough;
>       case IDR0_TTF_AARCH64:
>               break;
>       default:
> @@ -2589,7 +2588,7 @@ static int arm_smmu_device_hw_probe(struct 
> arm_smmu_device *smmu)
>       default:
>               dev_info(smmu->dev,
>                       "unknown output address size. Truncating to 48-bit\n");
> -             /* Fallthrough */
> +             fallthrough;
>       case IDR5_OAS_48_BIT:
>               smmu->oas = 48;
>       }
> -- 
> 2.17.1
> 
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.