[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH] xen/arm: Relax GIC version check


  • To: Vladimir Murzin <Vladimir.Murzin@xxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Wed, 20 Jan 2021 13:49:17 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d46rINQXHdPBfEE14otRu77IEYZASnQJZZvjW8s6JeU=; b=j2pjPfpqgTbkx88XcXvi0z5syvspzKwAGShwiUwY0b4Bfy8oBcq/kMa4M5vXtw8fxwmstWQTgEuRCbhOJ4OsDT1qwGXwGOn9seYtiAaxvOzCZup0phe9zz4rcmntqB/PxTNtSsQmntyJGCHV+irsGLwigticedISluDOT8sKM/j02Lh7vhqR/IwfcI+mCs2bWXtOq4/d4JC8sAtmKsPvxFIL0Y9ODv2AZyerluV9IOf98G4oNCDukQOx2RcAibggtf6VgwFuRjR9kes9QF4mdfNxJMeq9hS4EE2EBeMjGtjPghGihv7Z7B45oQ0E0rwtcYm/3USffS3M7o9YEpKFDA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m5M8tDtwpHTbTBE/6fCI6b1/m2kwkdDsAu0n34HEXzRgWQJW1fyH5heEa0IAyKhnPlGOXWCAvRp6eq2V+rQ1PdjIT4Ihx/ouyhjfXdpUU5u2xLv/CgZPV/arDunSdJ7Z2DzI6sh1Q9UTR9ySoo5LMz3T7UkczACU7/EDJlhOv1/40DlQyhWXZ61jPAw5kE5aQilzytnodDgRh9S7ithjAwA7ZihFwAcxYn7XKTs/jQyAz2Gn183XDqOyxM+RgQwWfMlxShFqHJFnNM+v7V86JxhhnYV1Om6LxdOs7DCUzSPw+FySVdx6bS0gX5Xdqgxsjysnmv3yONmeUpR4xJzY4w==
  • Authentication-results-original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Wed, 20 Jan 2021 13:49:42 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHW7x9HewSid3p/SkK1tULxfyE6Rqowh9cA
  • Thread-topic: [XEN PATCH] xen/arm: Relax GIC version check

Hi Vladimir,

> On 20 Jan 2021, at 11:26, Vladimir Murzin <Vladimir.Murzin@xxxxxxx> wrote:
> 
> Supported values are
> 
> 0b0000 GIC CPU interface system registers not implemented.
> 
> 0b0001 System register interface to versions 3.0 and 4.0 of the GIC
>       CPU interface is supported.
> 
> 0b0011 System register interface to version 4.1 of the GIC CPU
>       interface is supported.
> 
> 4.1 is still backward compatible with 4.0/3.0, moreover ARM ARM
> guarantees that future versions of the GIC CPU interface retain
> backwards compatible.
> 
> Signed-off-by: Vladimir Murzin <vladimir.murzin@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Thanks a lot

Cheers
Bertrand

> ---
> xen/include/asm-arm/cpufeature.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/asm-arm/cpufeature.h 
> b/xen/include/asm-arm/cpufeature.h
> index 13a2739a6..c6e5711b2 100644
> --- a/xen/include/asm-arm/cpufeature.h
> +++ b/xen/include/asm-arm/cpufeature.h
> @@ -17,7 +17,7 @@
> #define cpu_has_el3_64    (boot_cpu_feature64(el3) >= 1)
> #define cpu_has_fp        (boot_cpu_feature64(fp) < 8)
> #define cpu_has_simd      (boot_cpu_feature64(simd) < 8)
> -#define cpu_has_gicv3     (boot_cpu_feature64(gic) == 1)
> +#define cpu_has_gicv3     (boot_cpu_feature64(gic) >= 1)
> #endif
> 
> #define cpu_feature32(c, feat)         ((c)->pfr32.feat)
> -- 
> 2.24.0
> 
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.