[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH V4 05/24] xen/ioreq: Make x86's hvm_ioreq_needs_completion() common
Oleksandr Tyshchenko <olekstysh@xxxxxxxxx> writes: > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx> > > The IOREQ is a common feature now and this helper will be used > on Arm as is. Move it to xen/ioreq.h and remove "hvm" prefix. > > Although PIO handling on Arm is not introduced with the current series > (it will be implemented when we add support for vPCI), technically > the PIOs exist on Arm (however they are accessed the same way as MMIO) > and it would be better not to diverge now. I find this description a little confusing. When you say PIO do you mean using instructions like in/out on the x86? If so then AFAIK it's a legacy feature of x86 as everything I've come across since just does MMIO, including PCI. The code changes look fine to me though: Reviewed-by: Alex Bennée <alex.bennee@xxxxxxxxxx> -- Alex Bennée
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |