[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen-blkfront: don't make discard-alignment mandatory


  • To: Jürgen Groß <jgross@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 19 Jan 2021 11:21:39 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HFDSjVH+Td1ailRqBHdNwccecEOujYQNjO/T5gnFcuA=; b=FBFYmTkcqC76WPyz1HbSGlGTICeONN8o5QXoH/eckczuCZK0pEt5FXvRZS4aaKrA3H1TUlycNWf069diPf6gbxxSYr+COtrhUoibF3r1B/39LXDboaRE+pAlBJhln6e+1kFAWzt4fv03l+pGenuMT9YoOovpvcNxZBZeH6MxmDsVwjHtA2zX841BROMhxSrXNf4V+1w4UV3nS9KraXRZkKQ60uu8VxyH7dmJrL0em8z+EiG0+sJJvGTB7CuNWzu+3FWejIiaZTa4Iz1mkszJsPRQO/NrKb+sKGG8Ra2vbOKmYDO6GTr8jSPKyHzQrINQUfyb6/0K4guIFko34Wm5DA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rx2qv89ObsXUVHxHuCpF06QAbyTzkNzxZcZGD5Lnw854gm+PaVHkuHKntc3aQR0J2fGzpsYB8+/SkfliPKh1s5Mvv9KRv9bh7VtPXf0T1og/OljE3hCakCulUkjVuv8AkhnaUeywOWJv7k1Vc0D3mQR8/2hYsvaVTc7HHhFTqMJYLyXfcD0hzu9gnlWTencZcskzJWPgLuPNGUftbxE+hry8irqAZOeZW9PPK1O2hOeUU0HAGsOLUnp0tZwBzFSWWw55mkf3fN1I9B9Ygz/DkgE9T450WyfGmCusVLRBo1pZkI+4oSFlf/1R5DcmnD161B0FOCvQO75a/G7qTEnmOw==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <linux-kernel@xxxxxxxxxxxxxxx>, Arthur Borsboom <arthurborsboom@xxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <linux-block@xxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 19 Jan 2021 10:21:58 +0000
  • Ironport-sdr: UF7WhgJgjWLU9lGOyA3tr2U4FskkHg1LRT2LTcBI2t8idR4pP4NOOu74oP8M8ZqwGlGYxFXXLK 9LpwqsILAKrivRJyQdM+z+E2aYd4JSd5LQtUZ7GT6N5kU6zQ0++iUGTbGhHq9lXphEW+6CY2/e akixllOzaaE2GYV2iDNO3uXvx5Mn8rr+TzqpXlbp9ZxSXYhNuedGixSLaZGSD5JYTx3sigQD0H O+5HRwH5jq6YhDhI15RWTDK50G9quYjnbzwFBzpcIAJZQax9/Tgyl+x1czgk8aaYI3tlcaHRBy ffQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jan 19, 2021 at 11:11:26AM +0100, Jürgen Groß wrote:
> On 19.01.21 11:06, Roger Pau Monné wrote:
> > On Tue, Jan 19, 2021 at 08:43:01AM +0100, Jürgen Groß wrote:
> > > On 18.01.21 16:15, Roger Pau Monne wrote:
> > > > Don't require the discard-alignment xenstore node to be present in
> > > > order to correctly setup the feature. This can happen with versions of
> > > > QEMU that only write the discard-granularity but not the
> > > > discard-alignment node.
> > > > 
> > > > Assume discard-alignment is 0 if not present. While there also fix the
> > > > logic to not enable the discard feature if discard-granularity is not
> > > > present.
> > > > 
> > > > Reported-by: Arthur Borsboom <arthurborsboom@xxxxxxxxx>
> > > > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > > > ---
> > > > Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> > > > Cc: Juergen Gross <jgross@xxxxxxxx>
> > > > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > > > Cc: "Roger Pau Monné" <roger.pau@xxxxxxxxxx>
> > > > Cc: Jens Axboe <axboe@xxxxxxxxx>
> > > > Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
> > > > Cc: linux-block@xxxxxxxxxxxxxxx
> > > > Cc: Arthur Borsboom <arthurborsboom@xxxxxxxxx>
> > > > ---
> > > >    drivers/block/xen-blkfront.c | 25 +++++++++++++------------
> > > >    1 file changed, 13 insertions(+), 12 deletions(-)
> > > > 
> > > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> > > > index 5265975b3fba..5a93f7cc2939 100644
> > > > --- a/drivers/block/xen-blkfront.c
> > > > +++ b/drivers/block/xen-blkfront.c
> > > > @@ -2179,22 +2179,23 @@ static void blkfront_closing(struct 
> > > > blkfront_info *info)
> > > >    static void blkfront_setup_discard(struct blkfront_info *info)
> > > >    {
> > > > -       int err;
> > > > -       unsigned int discard_granularity;
> > > > -       unsigned int discard_alignment;
> > > > +       unsigned int discard_granularity = 0;
> > > > +       unsigned int discard_alignment = 0;
> > > > +       unsigned int discard_secure = 0;
> > > > -       info->feature_discard = 1;
> > > > -       err = xenbus_gather(XBT_NIL, info->xbdev->otherend,
> > > > +       xenbus_gather(XBT_NIL, info->xbdev->otherend,
> > > >                 "discard-granularity", "%u", &discard_granularity,
> > > >                 "discard-alignment", "%u", &discard_alignment,
> > > > +               "discard-secure", "%u", &discard_secure,
> > > >                 NULL);
> > > 
> > > This would mean that "discard-secure" will be evaluated only if the
> > > other two items are set in Xenstore. From blkif.h I can't see this is
> > > required, and your patch is modifying today's behavior in this regard.
> > > 
> > > You might want to have three xenbus_read_unsigned() calls instead.
> > 
> > You are right, discard-secure should be fetched regardless of whether
> > discard-alignment exists.
> > 
> > I can fetch discard-granularity and discard-alignment using
> > xenbus_gather and keep discard-secure using xenbus_read_unsigned. Let
> > me send a new version.
> 
> I'm still not convinced this is correct. blkif.h doesn't mention that
> discard-alignment will be valid only with discard-granularity being
> present.

No, in fact I think I need to rework this a little further. Just
having feature-discard = 1 should enable the discard functionality, by
setting discard-granularity = physical block size and
discard-alignment = 0.

Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.