[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libs/gnttab: implement on NetBSD


  • To: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 18 Jan 2021 18:54:11 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vcGuPK2KGdzHupRg18R432AugLQdjTPhXkl/nkgSVpA=; b=TfB25FW4nsxrjyz9Z+k48AKejQoZbu3VUVV8Ydqfpsz1iaIGhxI3HpFWDOEakHk0xCX+1zDIHQm+WDlr55JN/ZpxTjOFR2laq87pqceZUe0gHZBgNizdSsloETQkShvu9KcfCq8YrsRisN5S4V5ZoLXEcNO51jrZYxH0W9UWeTt/gPJKXILeEK4Mw0v2CnHjNoFjKKFNLluhpzyKOF0vKwFYI9CJwcJLUQ85zhtzr/Xfim1M94XZNQqVTb2+zAcN6rBgGK/kgZSV9lfN/YVr1kWtwRpNhGrmYBDQ38J2Y6t3+zJZ4YXDlLVRt6sMzXBWO6UdBtZLrKZfy39EqKrvyg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B/KFFajOS+FTmTF4/ZOTds+QjUjtztt0+y6F6gli5uERrhbC1pZ+fPniWqaowV8ONHkt97WeVutBtg4IPzhVpl+vKrwmeTlHkrNA/uOI2MKwg7fk3cAaGEppM1DzqRl+m3209ZDC1KTGST/UC8EHjdDcQFR53N9NB8I2bnmwXEZnkBeGAZIlxeDAzR7btU6Eb4ZakTI6tuH30V7Ad6nan6ZxMOVoiv7LPWBqJI/S6rQ4C7Anzbtj4GLkAUyBeiSr+XjIM2siDXjux+DHb100ieqXIyW2/UdgTTh0TFrItrH5JYZxws8VYFX4ZMfSatw4hSccIF/mEMzADy2Ibe+tvg==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Manuel Bouyer <bouyer@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 18 Jan 2021 17:54:47 +0000
  • Ironport-sdr: xGyN2qRQlCZOK4OQsMBrQA0Wfxz+K9TtTiq+LbKpN82CFFb5IgtRx6yxpsXxOSCZjZ7X0aQEo3 nRKHF77KFh7y5S0AoRWflXagem2l9bklvpbCP22Oe6fqBeROuRLN/qyRCuHQqRBrjh+HcHu1Re CqpQZhjSutdPZS0542VOwnoouO261m17dFeRF5W/buzvw4HL7+jO/rHbh8kJ6l0HerKqTG5meJ pgV7HcqjbRDuB9gAbi7MJbLKJKZZ8Qtwesb7Owok00V5cPA1gstRP8jfC45IrQ0yoyJqQIJgwT hDc=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jan 12, 2021 at 07:12:32PM +0100, Manuel Bouyer wrote:
> From: Manuel Bouyer <bouyer@xxxxxxxxxx>
> 
> Implement gnttab interface on NetBSD.
> The kernel interface is different from FreeBSD so we can't use the FreeBSD
> version

Since I'm not familiar with the NetBSD interface I can provide much
feedback, but you have some hard tabs in the code below which should
be removed.

Maybe you would like to be added as a maintainer for the tools NetBSD
files?

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.