[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/8] tools/xenstore: add live update command to xenstore-control


  • To: "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Edwin Torok <edvin.torok@xxxxxxxxxx>
  • Date: Mon, 18 Jan 2021 09:40:10 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8cAll7XNGzC+FWFUjcHlW8QTt0c0mzLrGlD1NXM8+us=; b=gnLwiKSfTqsMdGh41UUx6BV0ejS/NA/JUDRE9ub4vlOSofwyU9EUgMO1tYVcT+SI/C4XhViS9dfNVOTZVXUyMtcGM0E0slQyAo7a9xuur9TETqU+G+l+Ooy2cmLiTEDzBxIlPg7qQg5IYM6me019Hzc4mTji26XethKYb55ts6GNklG+CVMUwecj46OT6mbLdk2qGwkdQH65HutNx49Cao0zwi5MkjobyH+SBS7eGM/B0hSDDyPiCA1igEEFVdXpLMSvd1eLB3nn6fj54hmzV/M0U+hnNxBgAuRugx3gJ0hLDiknouizYVTaX5136+q/1dY8dWLXMgU6BKrG9kitqg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I/bY6VqprAowOjef1C+fZ+ozKHCTBGT8rnQ9Ii4vhK5SkJ5Oz7swTE8PlGV0Ubzn8xLcy5cd/l1n55lJJXJT9gIvERaBdhxxQ4Nvi/c4wZ+V6p0S/nyHsVDT9Eeq6Ejg3n4djU4xmwwOkVA0M/ZYn9SbLEXlpn7mLhZT49be7c+BeUPg72iHyL+4Scwn5PfWm/COyR+kt1mVf+V2NE0z0R1KrsF9tk843qTgBkAcyf/nIEiRB4EoH5o3L3BEKOnqMrM5NYunqKYxjwJ6ivFsodAxsr5lyeERCAELlZNXYxB+gSzwGR+H15TeK5OWHoKtUMLDWbwKCEPlt5hkS5NlIw==
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "iwj@xxxxxxxxxxxxxx" <iwj@xxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "jgrall@xxxxxxxxxx" <jgrall@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Delivery-date: Mon, 18 Jan 2021 09:40:18 +0000
  • Ironport-sdr: o3KYpFMvEERYDB3b2b7oVG94oaEN6b0ygj/0xKK1bwHj3plCLDTLwUQZb44bcnFMl3Piv81hbT UqGgs7HD39tKMdolOZaqM8lmRfAAjAVQMpS9Ggq9i20l3rdE2Ubr5nHzNMAiT9kWYFt5cxnmwF iddw8/pfbmUO9TLsYU6Rj30P/mZB+hmnUp8pfyUWs9bNoI/xfkzqNUjr6Q6VvEIMRKVl+g0/CF Ey1CoTq74gP3RmShOy5FYCawzIfV4IiRFkpLR5vToX6tMBmrnjVAO4XcpQIN+yMWTuoLWaJERu PZY=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHW7W6reh9Sy0G7+UqP/AM+Pn2A/aotIPUA
  • Thread-topic: [PATCH v2 1/8] tools/xenstore: add live update command to xenstore-control

On Mon, 2021-01-18 at 08:50 +0100, Jürgen Groß wrote:
> On 15.01.21 23:28, Edwin Török wrote:
> > From: Juergen Gross <jgross@xxxxxxxx>
> > 
> > Add the "live-update" command to xenstore-control enabling updating
> > xenstored to a new version in a running Xen system.
> > 
> > With -c <arg> it is possible to pass a different command line to
> > the
> > new instance of xenstored. This will replace the command line used
> > for the invocation of the just running xenstored instance.
> > 
> > The running xenstored (or xenstore-stubdom) needs to support live
> > updating, of course.
> > 
> > For now just add a small dummy handler to C xenstore denying any
> > live update action.
> > 
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > Reviewed-by: Paul Durrant <paul@xxxxxxx>
> > Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
> 
> Instead of merging multiple patches of mine into a single one and
> sending it here with my S-o-b I'd prefer a simple caveat for your
> series to depend on my C-xenstore series.

Yes, I should've added a link to that in my cover letter,
in the next revision I'll point to:
https://lore.kernel.org/xen-devel/20210115083000.14186-1-jgross@xxxxxxxx/

> 
> This additionally reduces the risk to miss any modifications in
> my series done in a later iteration than the one you have taken.

I've reordered the patches and changed the base, it should be gone the
next I do git format-patch:
https://github.com/edwintorok/xen/pull/1/commits

Will also remove
https://github.com/edwintorok/xen/pull/1/commits/47dd1d9b99b9210e94fbd4af28afee8088d5267
once I implemented the change in oxenstored to not return BUSY that we
discussed.

> 
> 
> Juergen


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.