RE: [PATCH V4 07/24] xen/ioreq: Make x86's hvm_ioreq_(page/vcpu/server) structs common

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
> Oleksandr Tyshchenko
> Sent: 12 January 2021 21:52
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>; Paul Durrant 
> <paul@xxxxxxx>; Jan Beulich
> <jbeulich@xxxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Roger Pau 
> Monné
> <roger.pau@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; George Dunlap 
> <george.dunlap@xxxxxxxxxx>; Julien Grall
> <julien@xxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Julien Grall 
> <julien.grall@xxxxxxx>
> Subject: [PATCH V4 07/24] xen/ioreq: Make x86's hvm_ioreq_(page/vcpu/server) 
> structs common
> 
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> 
> The IOREQ is a common feature now and these structs will be used
> on Arm as is. Move them to xen/ioreq.h and remove "hvm" prefixes.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>

Reviewed-by: Paul Durrant <paul@xxxxxxx>

... with one small nit below (if you happen to do a v5)

> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Julien Grall <julien.grall@xxxxxxx>
> [On Arm only]
> Tested-by: Wei Chen <Wei.Chen@xxxxxxx>
> 
> ---
> Please note, this is a split/cleanup/hardening of Julien's PoC:
> "Add support for Guest IO forwarding to a device emulator"
> 
> Changes RFC -> V1:
>    - new patch
> 
> Changes V1 -> V2:
>    - remove "hvm" prefix
> 
> Changes V2 -> V3:
>    - update patch according the "legacy interface" is x86 specific
> 
> Changes V3 -> V4:
>    - add Jan's A-b
> ---
>  xen/arch/x86/hvm/emulate.c       |   2 +-
>  xen/arch/x86/hvm/ioreq.c         |  38 +++++++-------
>  xen/arch/x86/hvm/stdvga.c        |   2 +-
>  xen/arch/x86/mm/p2m.c            |   8 +--
>  xen/common/ioreq.c               | 108 
> +++++++++++++++++++--------------------
>  xen/include/asm-x86/hvm/domain.h |  36 +------------
>  xen/include/asm-x86/p2m.h        |   8 +--
>  xen/include/xen/ioreq.h          |  54 ++++++++++++++++----
>  8 files changed, 128 insertions(+), 128 deletions(-)
> 
[snip]
>  #ifdef CONFIG_MEM_SHARING
>  struct mem_sharing_domain
>  {
> @@ -110,7 +76,7 @@ struct hvm_domain {
>      /* Lock protects all other values in the sub-struct and the default */
>      struct {
>          spinlock_t              lock;
> -        struct hvm_ioreq_server *server[MAX_NR_IOREQ_SERVERS];
> +        struct ioreq_server *server[MAX_NR_IOREQ_SERVERS];

NIT: this breaks the alignment... you should also remove some of the indent 
from the line above.

>      } ioreq_server;
> 
>      /* Cached CF8 for guest PCI config cycles */