[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v11 01/27] tools/libxenevtchn: switch to standard xen coding style


  • To: Juergen Gross <jgross@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 14 Jan 2021 19:07:53 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FqAl7d6g7y7Mrlwhag1CctonKBE2hPKLD9s1DJ5q7Z4=; b=jYLIld628zxDqxs1lpPDnaRs4xSKqvVywZ45n674NhiDMmVL2Xv/KcoAbI1o8+skkFNJ5p/8ZCJpnDShP4EPHBmfDdx66s/IT96/Pwjy7X4M9abL8LYebPbHE2gA1t01Ui+2mR5vGosCZ58nWFd0C0AFKzrmq0KrFwiB1Wil3ABDCHSot/fiQYB7q3cJsv8iKy6JBVm9uCKcMpH5dp2WUeYaMBKQV8cF8GQGh6vQ/iwbe+urYhbP1xAh+s8zG/MemXUfYYTO0jG3V4ZJI4gJPEoabpC+Z5mxgrq5uBT9aJJAWk9w8Rdp2NV6YwdIMVb5Vw+HLyCTf55X6KIhoR4xAw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CaDsncxCQJnoOYZ327S1GbTBvADlaAQoGXjV5gROhEjy2LNpto33AirNeig6eTxYMy0T4KKkhXHQ63vpoV162NP2kCwwsvit3zJu4QIq/62QRRCNPZ8pbXKC3UrP8cWokalMSs2UQl8QTZoDa6azUsiBE9Y539e9/fY8SBm+Bgic2JKBNM/hq1Ejr/ks0OhO1zCj24aEUR3REjIUnuOHYdPytFeaC97lNEAI8Ino2ETN4nfoD6Q0HLQh72V5i/oGLmlCuFsIPEeLoEWmuwA2HFdyVEOYD+d2p7cM+IspR5CDaDFtDvMtkerE9qFNUnxp625wZM1dKvo7tjmCRHZzyA==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 14 Jan 2021 19:11:02 +0000
  • Ironport-sdr: TJN8mYHoisxlTFZTYTQuLJGJj58fcwKPRPkwwTbXPKTqGkr+iUxuaQ83J1KCjREsHDHfdrH7EL Cfg8rk7/i2CaMj5r2DdLrbClw3gK/RfVZXXkXUUvABmGfFm6u1bSnCJ6Ben5nLT/W7Sw60yh1B wVk0Oe8X7QlmaNAy2EEtOvIypCFUnnKq3PXwo0ziv2GjXJFep2Djf2UZXXmMysASyh+/zSx7T7 MIm7sqqqxwbIfVO+Hw9VH3GbwS7qGgoYf5ymHXn+2gT3MLJqIZlmHwuNu/NorYlxJ2LqJ+4QO2 vBQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14/01/2021 15:37, Juergen Gross wrote:
> There is a mixture of different styles in libxenevtchn. Use the
> standard xen style only.
>
> No functional change.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, although if whoever
commits could fix these as well, that would be great.

> diff --git a/tools/libs/evtchn/core.c b/tools/libs/evtchn/core.c
> index aff6ecfaa0..5008810f4f 100644
> --- a/tools/libs/evtchn/core.c
> +++ b/tools/libs/evtchn/core.c
> @@ -42,23 +44,26 @@ xenevtchn_handle *xenevtchn_open(xentoollog_logger 
> *logger, unsigned open_flags)
>      xce->tc_ah.restrict_callback = all_restrict_cb;
>      xentoolcore__register_active_handle(&xce->tc_ah);
>  
> -    if (!xce->logger) {
> -        xce->logger = xce->logger_tofree =
> -            (xentoollog_logger*)
> +    if ( !xce->logger )
> +    {
> +        xce->logger = xce->logger_tofree = (xentoollog_logger *)
>              xtl_createlogger_stdiostream(stderr, XTL_PROGRESS, 0);
> -        if (!xce->logger) goto err;
> +        if ( !xce->logger )
> +            goto err;
>      }
>  
>      rc = osdep_evtchn_open(xce);
> -    if ( rc  < 0 ) goto err;
> +    if ( rc  < 0 )
> +        goto err;

Double Space.

> diff --git a/tools/libs/evtchn/minios.c b/tools/libs/evtchn/minios.c
> index 9cd7636fc5..8e9f77bb6b 100644
> --- a/tools/libs/evtchn/minios.c
> +++ b/tools/libs/evtchn/minios.c
> @@ -108,10 +119,12 @@ int xenevtchn_notify(xenevtchn_handle *xce, 
> evtchn_port_t port)
>  
>      ret = notify_remote_via_evtchn(port);
>  
> -    if (ret < 0) {
> +    if (ret < 0)
> +    {

Lack of spaces.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.