Re: [PATCH v11 01/27] tools/libxenevtchn: switch to standard xen coding style

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 14/01/2021 15:37, Juergen Gross wrote:
> There is a mixture of different styles in libxenevtchn. Use the
> standard xen style only.
>
> No functional change.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, although if whoever
commits could fix these as well, that would be great.

> diff --git a/tools/libs/evtchn/core.c b/tools/libs/evtchn/core.c
> index aff6ecfaa0..5008810f4f 100644
> --- a/tools/libs/evtchn/core.c
> +++ b/tools/libs/evtchn/core.c
> @@ -42,23 +44,26 @@ xenevtchn_handle *xenevtchn_open(xentoollog_logger 
> *logger, unsigned open_flags)
>      xce->tc_ah.restrict_callback = all_restrict_cb;
>      xentoolcore__register_active_handle(&xce->tc_ah);
>  
> -    if (!xce->logger) {
> -        xce->logger = xce->logger_tofree =
> -            (xentoollog_logger*)
> +    if ( !xce->logger )
> +    {
> +        xce->logger = xce->logger_tofree = (xentoollog_logger *)
>              xtl_createlogger_stdiostream(stderr, XTL_PROGRESS, 0);
> -        if (!xce->logger) goto err;
> +        if ( !xce->logger )
> +            goto err;
>      }
>  
>      rc = osdep_evtchn_open(xce);
> -    if ( rc  < 0 ) goto err;
> +    if ( rc  < 0 )
> +        goto err;

Double Space.

> diff --git a/tools/libs/evtchn/minios.c b/tools/libs/evtchn/minios.c
> index 9cd7636fc5..8e9f77bb6b 100644
> --- a/tools/libs/evtchn/minios.c
> +++ b/tools/libs/evtchn/minios.c
> @@ -108,10 +119,12 @@ int xenevtchn_notify(xenevtchn_handle *xce, 
> evtchn_port_t port)
>  
>      ret = notify_remote_via_evtchn(port);
>  
> -    if (ret < 0) {
> +    if (ret < 0)
> +    {

Lack of spaces.

~Andrew