[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] common: don't require use of DOMID_SELF

  • To: Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 14 Jan 2021 15:36:36 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZmcK9Y4uFBjkYUXcotUtMKLlgljfb7Qzt6kbazAoOsk=; b=PhQDqOgt9M5wSZ9JWnXdSne6ye41IjuvcQze1U9ByD2Xu7I/k/S4vf7SosenLd088tpcgChCXLSXGl7xebj6Tx+fVds0AK4dXyP0VfAsOlv8guC+IslMJEzumyYO6xZN2vhiSrN7x+xXseOCFSLfMYbwxrUxBqkS52EAUOcCtmN4BI193KvDVqOJGR2P3JyacdTQJqM4uvIJHfaAw7USSYCu/+5Me9Kz7rDUWlUx1JqE3vn4YcVljZ5MP1jV1DqxTCVx0TjV18vjbI+VAKFTN2gaGnI3fJ511ApNEyPWDzXKn02Ss7lnWRDl72LELIkVWzTQRSttsG/z/uz2KwciwA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fStARZBgBRHAEvIOEswh29lAOTutVR6Hkk8hzz56J+XFolPQQC+SHjt/AV11NthbcV3vYomsj2On1e9OwGa+3oeIt8cSxngdVoMGUkjTS73pOLXX8BRbha5+xHldQPp+O1Rug4+Tl8gnCGUlust34rTnIX/KqNJz3eeMbYlIZzGwwrdReKHNLAnCQA5vfby4dBJDZGymNh9Z8r3ym9R4NHnU/Y9R0lL1PJapxve1jq1Cbyy23cQfQwfAUAPlHaVMrA1VJOXFI8FA8z0RcvqR+uuBRe5eyn7wGVE7E7iErQ6epI52oJrj4gWABLgpff5fB/mqcA1Hd2lFQ3LoEpnayg==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 14 Jan 2021 15:36:53 +0000
  • Ironport-sdr: K1c623Yl8VkgDTkOhLNj7bzx4TLcpeLccEhYnIdSqAGw/5rjmCKlXyFhOiLnZuCnryA7rL0DO/ +6AmGBlfLvaGqJ75/VyN8F3HiYHZ71GjevWcHIAW1pO1wmWTECFA/emSDqOLuRGHZP2wgVePNZ AcjTVcxnSxPHc0GHXblEjpEJvXosrkFTh/c0TWFMGIUxDyoq2wZkt1xtUQ8xXx0XKka2r/2U4Y pfvckorrqnuNQCe9LVNo55pijBPEpGBQrGmAt5cMFSjvc/epMXmUJgn84tun5vDq5QJMG+jHZ3 2bw=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14/01/2021 15:30, Jan Beulich wrote:
> On 14.01.2021 15:43, Julien Grall wrote:
>> On 14/01/2021 14:02, Jan Beulich wrote:
>>> It's not overly difficult for a domain to figure out its ID, so
>>> requiring the use of DOMID_SELF in a very limited set of places isn't
>>> really helpful towards keeping the ID opaque to the guest.
>> So I agree that a domid can be figured out really easily today and in 
>> principle it would be fine to relax it.
>> However, most of the guest OSes will care about running on older Xen 
>> versions. Therefore they are not going to be able to use this relaxation.
>> So I am not entirely convinced the relaxation is actually worth it for 
>> existing hypercalls.
> I'm aware of the concern (Andrew has voiced it both here and in
> earlier contexts), but personally I think undue restrictions should
> not be retained just because they used to be enforced. We've gone
> this same route in a few other occasions not overly long ago, and
> iirc there are two patches going in a similar direction (different
> area of course) that I have still pending and which neither got
> ack-ed nor firmly rejected.
>> Anyway, if we decide to relax it, then I think we should update the 
>> public headers because an OS using this relaxation will not work on 
>> older Xen. A developper will not be able to know that without looking at 
>> the implementation.
> Well, DOMID_SELF exists because that's the preferred form to use.
> I can certainly add commentary, but it would feel a little odd to
> do so. To be honest I'm also not sure how helpful this is going to
> be, considering that consumers often have their own clones of our
> headers.

What I envisioned would be an RST ::warning in the "how to grant table"
guide for guest kernel developers in the sphinx docs.

Of course, this presupposed that such a doc exists, but its the only
useful place to put a note.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.