[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool
- To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Wed, 13 Jan 2021 12:51:26 +0100
- Cc: Claire Chang <tientzu@xxxxxxxxxxxx>, robh+dt@xxxxxxxxxx, mpe@xxxxxxxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, paulus@xxxxxxxxx, joro@xxxxxxxxxx, will@xxxxxxxxxx, frowand.list@xxxxxxxxx, konrad.wilk@xxxxxxxxxx, boris.ostrovsky@xxxxxxxxxx, jgross@xxxxxxxx, sstabellini@xxxxxxxxxx, hch@xxxxxx, m.szyprowski@xxxxxxxxxxx, robin.murphy@xxxxxxx, grant.likely@xxxxxxx, xypron.glpk@xxxxxx, treding@xxxxxxxxxx, mingo@xxxxxxxxxx, bauerman@xxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx, saravanak@xxxxxxxxxx, rafael.j.wysocki@xxxxxxxxx, heikki.krogerus@xxxxxxxxxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, rdunlap@xxxxxxxxxxxxx, dan.j.williams@xxxxxxxxx, bgolaszewski@xxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, tfiga@xxxxxxxxxxxx, drinkcat@xxxxxxxxxxxx
- Delivery-date: Wed, 13 Jan 2021 11:51:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Jan 06, 2021 at 08:50:03AM +0100, Greg KH wrote:
> > --- a/include/linux/device.h
> > +++ b/include/linux/device.h
> > @@ -413,6 +413,7 @@ struct dev_links_info {
> > * @dma_pools: Dma pools (if dma'ble device).
> > * @dma_mem: Internal for coherent mem override.
> > * @cma_area: Contiguous memory area for dma allocations
> > + * @dma_io_tlb_mem: Internal for swiotlb io_tlb_mem override.
>
> Why does this have to be added here? Shouldn't the platform-specific
> code handle it instead?
The whole code added here is pretty generic. What we need to eventually
do, though is to add a separate dma_device instead of adding more and more
bloat to struct device.
|
