Re: [RESEND] [RFC PATCH] xen/arm: domain_build: Ignore empty memory bank

[Elliott Mitchell <ehem+xen@xxxxxxx>]

On Mon, Jan 11, 2021 at 04:49:57PM -0800, Stefano Stabellini wrote:
> On Mon, 4 Jan 2021, Elliott Mitchell wrote:
> > On Mon, Dec 21, 2020 at 06:28:35PM +0000, Julien Grall wrote:
> > > So I think we first need to figure out what is the offending node and 
> > > why it is dt_device_get_address() is returning an error for it.
> > > 
> > > That said, I agree that we possibly want a check size == 0 (action TBD) 
> > > in map_range_to_domain() as the code would do the wrong thing for 0.
> > 
> > Already stated "/scb/pcie@7d500000/pci@1,0/usb@1,0".
> 
> Can you please post the full node for usb@1,0? I would like to check the
> corresponding device tree binding to see the expected format.
> 
> 
> > Perhaps the code should be ignoring nodes for which
> > which dt_device_get_address() fails, or perhaps this should only be done
> > for Domain 0 (where it results in panic).
> 
> That seems reasonable

What is the best approach to passing it along?  The dtb file is 46KB,
figuring out the right dts file isn't always simple.

I can state it was at commit cff5fa15e5d11758db426eee3524a5dfded3c62b of
https://github.com/raspberrypi/linux.git

No matter one's view on GitHub, this is also viewable online:

https://github.com/raspberrypi/linux/tree/cff5fa15e5d11758db426eee3524a5dfded3c62b/arch/arm/boot/dts


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@xxxxxxx  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445