[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] sysemu/runstate: Let runstate_is_running() return bool
- To: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx
- From: David Hildenbrand <david@xxxxxxxxxx>
- Date: Mon, 11 Jan 2021 17:08:38 +0100
- Cc: Huacai Chen <chenhuacai@xxxxxxxxxx>, Greg Kurz <groug@xxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, qemu-trivial@xxxxxxxxxx, Amit Shah <amit@xxxxxxxxxx>, Dmitry Fleytman <dmitry.fleytman@xxxxxxxxx>, qemu-arm@xxxxxxxxxx, John Snow <jsnow@xxxxxxxxxx>, qemu-s390x@xxxxxxxxxx, Paul Durrant <paul@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Eduardo Habkost <ehabkost@xxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, Max Reitz <mreitz@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Aurelien Jarno <aurelien@xxxxxxxxxxx>, Aleksandar Rikalo <aleksandar.rikalo@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>, Cédric Le Goater <clg@xxxxxxxx>, Halil Pasic <pasic@xxxxxxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, qemu-ppc@xxxxxxxxxx, Paolo Bonzini <pbonzini@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Cornelia Huck <cohuck@xxxxxxxxxx>, qemu-block@xxxxxxxxxx, Christian Borntraeger <borntraeger@xxxxxxxxxx>, Sunil Muthuswamy <sunilmut@xxxxxxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Laurent Vivier <laurent@xxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
- Delivery-date: Mon, 11 Jan 2021 16:09:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11.01.21 16:20, Philippe Mathieu-Daudé wrote:
> runstate_check() returns a boolean. runstate_is_running()
> returns what runstate_check() returns, also a boolean.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
> ---
> include/sysemu/runstate.h | 2 +-
> softmmu/runstate.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/sysemu/runstate.h b/include/sysemu/runstate.h
> index e557f470d42..3ab35a039a0 100644
> --- a/include/sysemu/runstate.h
> +++ b/include/sysemu/runstate.h
> @@ -6,7 +6,7 @@
>
> bool runstate_check(RunState state);
> void runstate_set(RunState new_state);
> -int runstate_is_running(void);
> +bool runstate_is_running(void);
> bool runstate_needs_reset(void);
> bool runstate_store(char *str, size_t size);
>
> diff --git a/softmmu/runstate.c b/softmmu/runstate.c
> index 636aab0addb..c7a67147d17 100644
> --- a/softmmu/runstate.c
> +++ b/softmmu/runstate.c
> @@ -217,7 +217,7 @@ void runstate_set(RunState new_state)
> current_run_state = new_state;
> }
>
> -int runstate_is_running(void)
> +bool runstate_is_running(void)
> {
> return runstate_check(RUN_STATE_RUNNING);
> }
>
Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
--
Thanks,
David / dhildenb
|