[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/5] x86/PV: _PAGE_RW changes may take fast path of mod_l[234]_entry()


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 11 Jan 2021 12:08:41 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VBlCmPSb9SLCfJbzEYb1L7r6U0Y8EXORYiw2NM5roCU=; b=B7LETVRJ30GfdmlGUu0pdR9fO7FnY3DPrIBhyo5FbV6a1ZYYp25UL60wl3P7MLUl9YN5hasgDhpDeuNzmTLTA1SCCwcu/ygNvA/rfaastoR9yBX5PD3D7qdo1cSQrJWHlnkU+ayVXtcw9vMuunOZkXTLig5zMCtgZREQriYlTD+jnNxq5ZfLXb/Sn8qIwNBZcgeH5AR/tYhWLXJ4TII+tkBbqANLKmDNFJLJLPzG4y81qPim0wdlEjzbpuhYqrjQdZMVdruJJzCTyAWp8/kHX1e/vVsA3J7FlRQjVFGYPl7M3WpcKEV6ouMF69jNNzHZn3RzCUC6XAYBkAfZZceIRQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AJrLgCXgBhyAZdxtZXaSh3Al4HuBf9JXXhl9ELEfQPHnAellNig07sRDiowBr6vmX3DSt+Au8p9QeZ016fGx0qqagXJPAn2R2CvBo8KjpUkojQsyr6+tZY9QR1PQK8RRvfMrbhd/WPTTYDI5hErQBckomCWmLojinrQ0cYoa50LGBpUTtHXZSUFFhLWJ8iBdO7UqsX3IUwLmAB74optawEq5pHJXlg9rbLcli8HOpeD9rUCaLf0h0vOM1SRMnyp49AULUMK1/NgvrdQgdZPcki/14k/cwxFnhab6fJzkUtPzOWcegvW901hqmm3u7q3ZW6aZBchPPVbwOEsDcBP2cA==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
  • Delivery-date: Mon, 11 Jan 2021 11:08:52 +0000
  • Ironport-sdr: HLcvZl4+BxUoMTTuq0z7UqDF5q3M+HtW2hksAEyo6oOBW//QsN1nZMlrZ85E8ZrEd3KdJ6PMky x33QxNdwSTU9/qR03Tu5F9pGPN5EkZSByx4TCQpKY+2cGmisXU+r0zpcO2uABuvShtqIdOrLxP it0C+60gLX82+1uM8A9GyQYLlSpu2Mi6bQ3DCMX6Vr0MumURvYUJuANpkgGf/mId334f9svFPF mJjL65u6Lw+bU7/k0R4CXaxHdIvEYLiPTghxoyFBn+RVOW4W1a034SbmwnE/F9UPRmpTjDjqBS xIQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Nov 03, 2020 at 11:57:10AM +0100, Jan Beulich wrote:
> The only time _PAGE_RW matters when validating an L2 or higher entry is
> when a linear page table is tried to be installed. Therefore when we
> disallow such at build time, we can allow _PAGE_RW changes to take the
> fast paths there.

I think it would be helpful to note why PDEs with linear page tables
aren't allowed to have the RW bit set, likely here and in the comment
below.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.