[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] vPCI/MSI-X: fold clearing of entry->updated
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 5 Jan 2021 14:12:04 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NJIMqH+zSSaz3lWxj5+X6LttCdzUqpoDWqaD2upskak=; b=DJPSRVd+JVN1Wo4+vKc+nzWMHYDWyYdKr+SXxeznUBKcREb0V11UdXh0vpXEq1peEJIGdf2H0qbI0g9ogTdoLva0ibSvnnAj3YSRdrNM9y4g3Y1qykwWRwp8js/ITEw7A+R3KZG/Md54vOJJ4zJyzXKYe1oQSxNmCmwR3ICaKqEoO23IfAEMf9x9Fx3kK+tIQOZmPdYbCJW0YT0ngt3XXuhmsqdfxijbPp3bP/ycCPNQK+1EpXSymPjXKpcwBCUGKuiSF4aXpKgAr+cKUhtwkN8KMPNadJVDkngRsgY3DdQrpl1leHuIVud4l/dE2FEg8KDVvQO4PC9+euM6jGcEgw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cz3j4DLsuMeP2GtPfrd0+Naja0nOs+Xo+8B6pkZ9AJtUa4a+5AaqcAvV9d9xOQDr4T7KCz4fNAN9O4WA8MeRuB+eEiqPmeyRwPyJNDdtqdOwLVVAR+xrC/66PVGCw+oDqb/qOjl1chERN9FSNcsAGTAHcAOI4zYAoM+95nLXM8JkbIHLLsl9w126a/yUzy8dAirhyCBj0dSQXc4s500oKFu2P7Je6zGXIXsHi/MQStAF56xcDEsBjkaElspeftu6JfcdTCiYQpzb41R+IZHNlDeHOvTDxlYwBKEbPtvDfXWKZT/Jwf1vm05qXD4pyckv12g9j01NjExqbLWNBXudIQ==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 05 Jan 2021 13:12:23 +0000
- Ironport-sdr: m3ucHoJD55r3Vw1CdBHqyXsr/KRI6QJ921LRECvvl7y1xzQAMTe+tpEOQJwbmHr1DCDIzD05yD d2QGoyyPF9YXBcCNpH4zy9MxcEs4TDdcJGv9Omlw7iwR5/j2Jbdz6d7b3isA5YDV439bQfcr2A ifn18PVvFs0VGAFdNL+8nlKemXI1Jc2sUaJRBKp5kVZiiz6/ZfLwZ/AKqUtuzJLT9zNlVXXG9G r6St11ivV452cqOHdciKQf8HnFUR/A9hbcTkYx80CNnHHa43jYnnykvU8SrNvo/Wb38uZiNXQL Md0=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jan 05, 2021 at 01:39:54PM +0100, Jan Beulich wrote:
> Both call sites clear the flag after a successfull call to
> update_entry(). This can be simplified by moving the clearing into the
> function, onto its success path.
>
> As a result of neither caller caring about update_entry()'s return value
> anymore, the function gets switched to return void.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
