[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/24] Implement foreignmemory on NetBSD
- To: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 4 Jan 2021 19:24:41 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AfR4UOGY9rPW9TbQq5Dsh/1rtUJMduJz1sBLjTzmvWk=; b=UerlriztP0+AeyBjb+x3dGm2FZJ9oGO7rJhu05X0r1TFXPehqx/AEif3b+r3agxPcOeddfC8TOUiqPaPGvVBMxfNoUrCzQxLShj9cBBnLMlBkZp5z47xddL8dGyArz2Kcz5ZmdVIYZngw8vfgFqX3Jg70Gu/+BrtuzhNeIBi9yzMOm5pq1j2vdN7u/ddcjk/NM+N54zyP0sIAL/iTkoqNbxPmzFijHXGOdMkOdIkxe3oA71gehjnRVgVmTFxBfN5ARp6HMlSnnQRxN7gMmmNmeVsip6813CpXQ4v9W9GBRQclKMFKQ/HfCK4GloBoqH3MsNWan8FNEKR0kJjXLLpnQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I5/o0NYCmU50l3fiXU1dkKz44HFOwXqK9FHixVrLfB34rllUcbMyyy2QsPKznfcq3f/HJgx87TKAAHrOO+fXBU6O6DcnQttdmvw1RwpnbuC6KgBOwBzVveqUvH2EIikuHrO2ysXZYoHzuRQMx1SIz7Jt/04I9XfqMGzOgPIPe8XNS8W1nQiA0YmbZETFTYVf743sK3T4AT1VYyi67RRwr1GUWdGWOkXRPcat3U4gWPD3Gc70dF0lqEmViPLtmD0jL1WIYA7Pe9uN1hDG7X0ZElaMXNZSOWoA1oqopMdfFjN0mlsBMhOVFcbTkv7b21BbC0AlXHyrGPbGoP535MaL6Q==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 04 Jan 2021 18:28:04 +0000
- Ironport-sdr: IZT8R2Tgf4t40tyHjUj2HSONtZjc9TKipu+fFSlfju9a+fSOzcmHDjrz9e02GtV6yg0W5ol5wi UKIDeGMNJJs/zm3Sc/98Ba1KCTV4V6ksX+iIAcAktRsNgBFl6aD6ryzSOodZ9PPSquDGKub2gQ oMBtBzRhLUzV+Ns5z42nV8Noftfq1Y3nagD+zQMJ6VjX4Vu4qkTMyz7tHCb/+wj9m5sH5XnIOx xFLatqDHUF0j3Vbdl86zJcnjNkgfjyeVuNE4j7XYhW7vEnLEdC5SChbernyD0/U9m655U5NR5F p5s=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Jan 04, 2021 at 12:30:44PM +0100, Manuel Bouyer wrote:
> On Tue, Dec 29, 2020 at 01:46:30PM +0100, Roger Pau Monné wrote:
> > Also a little bit below these prototypes are the dummy implementations
> > of osdep_xenforeignmemory_restrict,
> > osdep_xenforeignmemory_map_resource and
> > osdep_xenforeignmemory_unmap_resource. I think you at least need to
> > modify the condition below so that on NetBSD the dummy inlines are not
> > used?
>
> This is !defined(__NetBSD__) so it should not be used ?
Right, I think I somehow overlooked that part of the patch. You are
indeed tweaking the define so it should be fine.
Thanks, Roger.
|