[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libs/devicemodel: fix test for DM_OP availability
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 4 Jan 2021 18:33:35 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rau/qVNuqHf+E87QDYPfetCIub198Ef1Rc1cA0u1rTM=; b=EcF/VrGU/a9QCPJz+H1C5Eqgz3XaJwjAifdbUf4zjMJrgIGSa2G5pTfz4j6uj+BDerE1tYGOm+RJwM2PI+R+paDh+R9wpNr9mQ1wUY9M0orSFkO0foqCFLUH70M1d2S09c6GYd7ekYbn4eGpUqa5Pg/m5SW1+k2fj81aaa0uarvbM4lzS6nhvVvW5aMPexurUV3K1mf5YZR1BrQ1hqiXSAqBv+iGZNxlLH6BAEfmeeBYvAHPMn9Y5EdRebtQnBLJlg4IahPJnxNrVZioBTJcrs1IfHCYUuZa4UxbtuC5h4xWlKDng9IlkmSTnuqFnRS4BGwfJ6Y9J4L1MxAf9y2cWw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SUMg5Ep0lbDD6u8dX1VmLq8rLZq1AMMS492EFIYzspnMBI3huTypDimBQ/1XVigLNn3AOResgjoMf/JrGa4kuoZgmK4EHZ46lF6Jh9V0eFXu0n48GC3LiUuv6D8ctBegdkglVnnk9G3UDjkqodn9jS849vgOTQWSuXlv9YLO5AACvAElNJ3jB3WTuJ8KPZNDvCo9zgT4x1Lf69zWx0WrpRs9wcf2JcodNc2oV8kPk6iB/DnZ95iqvzqhxnj2n94P0B9ohTJQ4aMmw3tW023ErSch2yBxIGQOWjJtvVWF3nB3cNnbGIBp0ZI3tPuvTtQ2PAQPsGTXbRUf8WXwbexkfA==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 04 Jan 2021 17:33:46 +0000
- Ironport-sdr: 7lawoXKQzD8JgWo5ViCY2r+PbY9jYuvOJSpTBTmx9htVRY141iivN2XRcbFBW7TVfO/LLQiSAs nvARSE1dQTmKTWbUzhf2t4x8H5TqWHppX9LGq6wui+NkJA7amxwjfY19Re+nEv2qjNEVonbI33 wQHfKyRekpqpVhJCkYgHNZFvwQxn3bty/c7OWOnB5D+5ndAICEmlu9NhXWNoztfRv2U+xxJyaz 4IYakppk0Q73Aibw+bPOM5rm0Ni6oUhBpoHsem9Y7Hk0xRs0ubNaRkPQoMgDGSPgw/vlgwF5At C5g=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Jan 04, 2021 at 03:12:02PM +0100, Roger Pau Monne wrote:
> Current check for DM_OP availability in osdep_xendevicemodel_open will
> always fail, because using DOMID_INVALID as the domain parameter will
> make the hypervisor return -ESRCH, which will disable the usage of
> the DOM_OP interface.
>
> Fix this by checking the errno code of the test ioctl against
> the privcmd unimplemented errno.
Forget about this patch, it's my fault for not realizing Linux privcmd
checks that the num is != 0 before issuing the hypercall.
Sorry for the noise.
Roger.
|
