[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Ping: [PATCH 2/4] x86/ACPI: fix S3 wakeup vector mapping
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 4 Jan 2021 16:13:46 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DnBW8ky96Js1nDXnqMBGU4d65qlQ71xjVJzSuu7fB+M=; b=jzG7auea2DJ8hwojW20jqwVhYeTWQtzIswY0EIF6pRLrDSVep78ct8F4pmcwkUp27O6pOuOoVI1yYqEMqKv20WImOPxJVWUpz/52KZ7MqneEzwhL7eze3liqt1CGYB0bGPVgxcitHKtU6JNMScV2L+iUZG/QJLazLgygAlQ8Pwaq9657m94pSx4Eimu8sJh+QcQiJJofJaMFJq0nF9Vlek36QfTK6nnpBYfjgwiCYTMa7K/BRtPtmFghvQQimc7Q+F/j5b9vG3XXx2POzGjDAlX5SZRr41sk43lnHbyAX9I113UGu82tP5FOpJ9qyA7b+7e6JWxQjC858nqvMInRng==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ehx3egXH4HsTbk5SgF5PBWzd9dtgt+F0jDJYT6JdQReJdZoAb3DEiC1JX4dlnvz8FQGaXg9MNYHGz69ZFSgciETeIggBz1iDqtStFRh4nGPnCqrCC06uQwbPc2mQ3PxVQtjCHSevUmadklvoeoU2qj6ZaBb+08HVSiWZEoqWNh6O2Tyd6i86KuMEB4vEk42JAaOW5+xqBBjmUqVkBt+ZxdQysikdn6+1WaKfeT0XDMRbjZJ+HPwfunRg7QidCJXhn0I6NF8+w/ZgYztFmIBspNkXP11bkafGEgNHLEZRtlsqqyeaDh4h/NBwTQ9Dff/TKMVLud2VNXGTuWyGJCAV0g==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Mon, 04 Jan 2021 15:14:14 +0000
- Ironport-sdr: gnrI8RwDyOzlLurUhAr5fM0Zecsg+A+d359BgTSv6angcHhEZj6WsZO7TrowDmYW15JCuLDCS3 2xqZd960sfDy1ugT87D9GRFhnqt9OUKY37zT0g6Pia8WA567UF1/XG4+7BxsbSfNc+wBSWLqdd E3XvdJ8OtqmT9I4eFbK9Xr2Yrqy+tjz/Aep+TSZEgJqoJhT/yByCZ6NGEjgXr0amLHoQ+uRKY5 y57qE+BnUeGyNMrEqV9BIFpmNIAyASGN0+sna2/xF3XhH0a2E8uduWIN+pBqJeo2gSCcHrTojW Ktc=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Jan 04, 2021 at 03:03:07PM +0100, Jan Beulich wrote:
> On 29.12.2020 11:54, Roger Pau Monné wrote:
> > My preference however would be for this to use vmap. Could the mapping
> > be established in acpi_fadt_parse_sleep_info instead of having to map
> > and unmap every time in acpi_sleep_prepare?
>
> Establishing a permanent mapping would seem like a waste of resources
> to me, no matter that it's just a single page. In particular if the
> system would never really make any attempt to enter S3.
IMO I would rather have a simpler path going into suspension (ie: not
having to create a mapping to get the vector at all) with the cost of
using one page of virtual address space permanently.
Thanks, Roger.
|
