Re: [PATCH 05/24] Introduce locking functions for block device setup on NetBSD

[Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>]

On Tue, Dec 29, 2020 at 12:29:09PM +0100, Roger Pau Monné wrote:
> I think you want tot CC the tools dev on this one, specially Ian who
> knows how the Linux one is implemented and can likely give valuable
> input.
> 
> On Mon, Dec 14, 2020 at 05:36:04PM +0100, Manuel Bouyer wrote:
> > ---
> >  tools/hotplug/NetBSD/Makefile   |  1 +
> >  tools/hotplug/NetBSD/block      |  5 ++-
> >  tools/hotplug/NetBSD/locking.sh | 72 +++++++++++++++++++++++++++++++++
> 
> Seeing the file itself, I don't think there's any NetBSD specific
> stuff, so we might want to consider putting it in BSD/ instead, so it
> can be used by FreeBSD also?

I'm not sure if FreeBSD needs the locking stuff.
Also, there are certainly differences in block device handling between
FreeBSD and NetBSD. Both OSes have diverged in this area.

-- 
Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
     NetBSD: 26 ans d'experience feront toujours la difference
--