[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] x86/build: limit rebuilding of asm-offsets.h
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 28 Dec 2020 13:00:28 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y0T32xHlRne0BfcFdX3BiJ4ygytSnFj2q7tLSb7MWko=; b=JXaWgtVBAVvLPINJt/X9Z04Wr1Zyy5eYzKcxg9NyuVGec8zuilJhCCqWmMGyNEwYGnZRc39UcVUz0Rc9i3UTcmNmE/jDAv84F082dOsKe+wII5V9HIYHv56Po6Lp1B+PQrMdg7xuRkkAOHDkDUzoSBKAKCqJ9lyAWrmwLoNUJq0o9ws1SdMv2pjZNdskJGXASf7OwzfDaqgRmcx55/fXZlWim0N5oiRhBsSB4/CTrLOLdndCKn+Jf2Co7mTGTgSkJCcAeKA563wG1nkU7MabxdzKDkV8Fjv7K2Mjo8hwySfIe5Tg9JIGW1OrV4y9a+H6XgACICh1Tq5YetsGDQegTA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XrADel6kosonqSqljEoVSqEqY294tkgVQmEfndrJ1XAf0mmAxtYfhk9JH+iDuBaPwGHNk3oqKaqgzD6/0PiFtv/XdH9sLeZbaW0PyAHYQpC73ZqM7Wt1EJyDP8ZlHXoPY69b/+DLb5KOUjYxMA85lYE+lpDyqwZRnI6zhiR47+gY8UabhoKSY+Xf+MCts9slt+PaIPeTorBFDfrCnYsCqbtzJdyAw3QGOwH2fLHz8bYymCrB5GRIQJwlH1V+MVdmuI/NgtWwPmj22dGSiBTHzQjH/YylQZsWbGuiUGnXRTvzkniJWRLObY9q3jLx+A7EVTOeqxtZ6Qa6LrfGJ6c9hQ==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 28 Dec 2020 12:00:55 +0000
- Ironport-sdr: SB8w2xG7i13nn6+ULaRq0/cNheGhi7GuEpO0tkJiEZypHoCPp/uf5NUL0i+0k5HiSkD8uN296F 59sMgf0/X1W2owWetdbQmL/GKZeM484G18laLlcoH5QPj7AT4UY/KTQze4LcIp0MV+UheWVQD1 vBsdFzC7wqMve/zk4M9uv1L9loYIH7/Z+ZCuHWuwOvPRJZJkYPU0k6Wu790jxJ8kzPJiEk59KV a4X0Rh13jjddGNrsCSN4y60rGKSqcnuidpeYKIapxIs5fX0S2fiS1TUwmZCblHEl5bxLZgSQrD 8jA=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Nov 25, 2020 at 09:45:56AM +0100, Jan Beulich wrote:
> This file has a long dependencies list (through asm-offsets.s) and a
> long list of dependents. IOW if any of the former changes, all of the
> latter will be rebuilt, even if there's no actual change to the
> generated file. This is the primary scenario we have the move-if-changed
> macro for.
>
> Since debug information may easily cause the file contents to change in
> benign ways, also avoid emitting this into the output file.
>
> Finally already before this change *.new files needed including in what
> gets removed by the "clean" target.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Perhaps Arm would want doing the same. In fact perhaps the rules should
> be unified by moving to common code?
Having the rule in common code would be my preference, the
prerequisites are slightly different, but I think we can sort this
out?
Thanks, Roger.
|
