[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] lib: drop debug_build()



On 21/12/2020 16:50, Jan Beulich wrote:
> Its expansion shouldn't be tied to NDEBUG - down the road we may want to
> allow enabling assertions independently of CONFIG_DEBUG.

I'm not sure I agree that we'll ever want to do this, but...

>  Replace the few uses by IS_ENABLED(CONFIG_DEBUG).

... we should be aligning on CONFIG_DEBUG.

>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> I wonder whether we shouldn't further abstract this into, say, a
> xen_build_info() helper, seeing that all use sites want "debug=[yn]".
> This could then also include gcov_string right away.

I think that would be a nicer way of doing it.  It should probably also
have some trace of CONFIG_UBSAN in the resulting string.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.