[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 8/8] xen/arm: Add support for SMMUv3 driver
- To: Julien Grall <julien@xxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Wed, 9 Dec 2020 18:37:08 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ajGJisMwZEtO0TjadzZL+EJYvuJe7ZlzAnjlmFp6Mh8=; b=OHq+zC2+tUFfQharKyIx5hbYiLLC4Uo1zffx2wTA9JWkcQANZYS/6mwnwI8i2kDJINpYyLiwC/nbaWyp4CgUdUU/bob3cE/V3g8+5wRgAluDQ17lH7oDsee8ibUMgFxmY1Rhp6QIjByJoBjfsfJMNp8KRVbAOdGDeqI5DqUE0e4cfcUe2G58BOF7eJs9CYegCJIWlH/TmCN7+tLGAAQtMblShV0sqVtwG2XPsoSum7JgcuFrI+KL86RjQH9omqldNFDHBEu5tMKRquL63MSknnPDH7ymYFtFhQZCX35HpoelqIrdLMZejgmAKBY+tiRS4zLXroQe9y6CorjORwLoVQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NywbdgJcJ7ncXVP+Dgj1ShrT9XmD6sh6NV1Tp61CMV5Uh8UQhHvPA3t3x/+y+Jg7RIryIWU0XLR/leptYQ+6nAI6+2/Xbna+s1y6rVPDBh4xLeqX7lM9BZ0XDxDV/3KKlyKifxMWM64jgC27Ioww9YTBt0isPxoCcKpVDsSeboPqsz/v9jcmdOUa0vRsSZ6bT4kLy7Y8GkInpf8QyHkvgKi4kgEvxu/9rKvhFquK21suKhAbi0rymztcZwgWev2O1AtzllbGkeRQdP9ESY6zsM2SX8KRfUMiAXDcPyRg+Lcd8LZ4a34IRM5Am3FD5prhgHhktta+mdoBy/87xc82EA==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 09 Dec 2020 18:37:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWxBX/ttp8YMNqT0KunkbXuSldmKnkBpwAgAeVnoCAAFuAgIAAEZOAgAGYzQCAAGhiAIAAbqQAgAAXOgCAAJwRgA==
- Thread-topic: [PATCH v2 8/8] xen/arm: Add support for SMMUv3 driver
Hello Julien,
> On 9 Dec 2020, at 9:18 am, Julien Grall <julien@xxxxxxx> wrote:
>
>
>
> On 09/12/2020 07:55, Bertrand Marquis wrote:
>> Hi,
>
> Hi,
>
>> I also agree with the issue on the spinlock but we have no equivalent of
>> something
>> looking like a mutex for now in Xen so this would require some major
>> redesign and
>> will take us far from the linux driver.
>
> I agree that keeping the Xen implementation close to the Linux one is
> important. However, I view this has a the secondary goal. The primary goal is
> to have a safe and secure driver.
>
> If it means introducing a new set of lock or diverging from Linux, then so it
> be.
>> I would suggest to add a comment before this part of the code with a “TODO”
>> so that
>> it is clear inside the code.
>> We could also add some comment in Kconfig to mention this possible “faulty”
>> behaviour.
>
> I think it would be enough to write in the Kconfig that the driver is
> "experimental and should not be used in production”.
Ok . I will add in Kconfig.
>
> Ideally, I would like a list of known issues for the driver (could be in the
> cover letter or/and at the top of the source file) so we can track what's
> missing to get it supported.
I will list all known issues and short coming of the driver at the top of the
source file.
Regards,
Rahul
>
> Cheers,
>
> --
> Julien Grall
|
