Re: [PATCH v2 7/8] lib: move bsearch code

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 07/12/2020 10:23, Jan Beulich wrote:
> On 24.11.2020 17:57, Julien Grall wrote:
> > On 24/11/2020 00:40, Andrew Cooper wrote:
> > > On a totally separate point,  I wonder if we'd be better off compiling
> > > with -fgnu89-inline because I can't see any case we're we'd want the C99
> > > inline semantics anywhere in Xen.
> > This was one of my point above. It feels that if we want to use the
> > behavior in Xen, then it should be everywhere rather than just this helper.
> I'll be committing the series up to patch 6 in a minute. It remains
> unclear to me whether your responses on this sub-thread are meant
> to be an objection, or just a comment. Andrew gave his R-b despite
> this separate consideration, and I now also have an ack from Wei
> for the entire series. Please clarify.
It still feels strange to apply to one function and not the others... 
But I don't have a strong objection against the idea of using C99 
inlines in Xen.
IOW, I will neither Ack nor NAck this patch.

> Or actually I only thought I could commit a fair initial part of
> the series - I'm still lacking Arm-side acks for patches 2 and 3
> here.
If you remember, I have asked if Anthony could review the build system 
because he worked on it recently.
Unfortunately, I haven't seen any answer so far... I have pinged him on IRC.

Cheers,

--
Julien Grall