[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Ping: [PATCH] libxenstat: avoid build race
On 18.11.2020 15:27, Bertrand Marquis wrote: >> On 17 Nov 2020, at 09:42, Jan Beulich <jbeulich@xxxxxxxx> wrote: >> >> Olaf reported observing >> >> xenstat_qmp.c:26:10: fatal error: _paths.h: No such file or directory >> .../tools/libs/stat/../../../tools/Rules.mk:153: xenstat_qmp.opic] Error 1 >> >> Obviously _paths.h, when included by any of the sources, needs to be >> created in advance of compiling any of them, not just the non-PIC ones. >> >> Reported-by: Olaf Hering <olaf@xxxxxxxxx> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> > Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx> Ping? (I guess this one is again simple enough that I should time out waiting by the middle of the week.) Jan >> --- >> A similar issue (at the time of the report) in the building of >> libxenstore was addressed by Jürgen's 9af5e2b31b4e ("tools/libs/store: >> don't use symbolic links for external files"). >> >> --- a/tools/libs/stat/Makefile >> +++ b/tools/libs/stat/Makefile >> @@ -30,7 +30,7 @@ include $(XEN_ROOT)/tools/libs/libs.mk >> >> include $(XEN_ROOT)/tools/libs/libs.mk >> >> -$(LIB_OBJS): _paths.h >> +$(LIB_OBJS) $(PIC_OBJS): _paths.h >> >> PYLIB=bindings/swig/python/_xenstat.so >> PYMOD=bindings/swig/python/xenstat.py >> >
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |