Re: [PATCH v2 15/17] xen/cpupool: add cpupool directories

[Jürgen Groß <jgross@xxxxxxxx>]

On 03.12.20 15:46, Jan Beulich wrote:
> On 02.12.2020 16:46, Jürgen Groß wrote:
> > On 01.12.20 09:21, Juergen Gross wrote:
> > > @@ -1003,12 +1006,131 @@ static struct notifier_block cpu_nfb = {
> > >        .notifier_call = cpu_callback
> > >    };
> > >    
> > > +#ifdef CONFIG_HYPFS
> > > +static const struct hypfs_entry *cpupool_pooldir_enter(
> > > +    const struct hypfs_entry *entry);
> > > +
> > > +static struct hypfs_funcs cpupool_pooldir_funcs = {
> > > +    .enter = cpupool_pooldir_enter,
> > > +    .exit = hypfs_node_exit,
> > > +    .read = hypfs_read_dir,
> > > +    .write = hypfs_write_deny,
> > > +    .getsize = hypfs_getsize,
> > > +    .findentry = hypfs_dir_findentry,
> > > +};
> > > +
> > > +static HYPFS_VARDIR_INIT(cpupool_pooldir, "%u", &cpupool_pooldir_funcs);
> > > +
> > > +static const struct hypfs_entry *cpupool_pooldir_enter(
> > > +    const struct hypfs_entry *entry)
> > > +{
> > > +    return &cpupool_pooldir.e;
> > > +}
> > I have found a more generic way to handle entering a dyndir node,
> > resulting in no need to have cpupool_pooldir_enter() and
> > cpupool_pooldir_funcs.
> >
> > This will add some more lines to the previous patch, but less than
> > saved here.
> Which may then mean it's not a good use of time to look at v2 patch
> 14, considering there's a lot of other stuff in need of looking at?
All of V2 patch 14 remains valid, there is just a generic enter function
added in V3.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature
Description: OpenPGP digital signature