[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/8] xen/arm: revert atomic operation related command-queue insertion patch
- To: Julien Grall <julien@xxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Thu, 3 Dec 2020 11:49:42 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nl/NRmHDmxQaVqoLAx3cifSnwO2lV9rCIJZ7zKBLR/g=; b=nDR1zGAIbWDe7j2vm9IVmZMc4Feu340IK6sAOuZRgHr40zB1YEQraVN4g68O4cLAJr8lTWhaHZnK7XB8ng20D2nr4gwP4ErKyDfFv+ZJHdjEQSYYtPtGJAS06lhDvn357FLc7CMG2yDQOb1MC0Wck6oJUN6n3ZpF0K21n6hXrRHTftscDRewsXiaLsq7+ZfVH8gFxDykDmaPkrzQS7BBNn9ohd3TuMTKDZF0NJGTbcQEaQl+8684uBIGkMM5BHK0r5qeGQZR5HP327QhiPq63Lz+CX+HDQiXTO85vbn1HPQKpRkIdy3z43BZyyqd3Vu3NyVrtyvYFe8vJwFuAfSWTw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kios/xh+ln7Fv/Eggimi55OkNWM191m0xWBYgI80hmTTdNbeGzZENhB3RJyK+Wtom8EtQSWIS3yP6t89GQnjSSR4xZB8Z0qlblzP5NeOF2eCMrUx4vjDwrsKCNRa0HiRWIG0vnMbMul9pQ3NClnuoCQehGK7BEhf0/H8TylXzvfAeEzgjOVhTwZIn4tafQ/P/eeriKLi+C/Ste/qIxldtyVHEQvyOMxXLPKRNIJtAm4nJJ/aKjSbGRTlWjaSCFtkvPRYWCfp5bl1KgDsfLzW1wXtArn9iNqBhyJ2jEt5B0IOuYFtud5Q8xkbubD8GxzXu4V4/0ylU6TzCQ6CZB0wXw==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 03 Dec 2020 11:50:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWxBX9ux1e0/RKik+PTdn4Fk42F6nj2m+AgAFyKwA=
- Thread-topic: [PATCH v2 2/8] xen/arm: revert atomic operation related command-queue insertion patch
Hello Julien,
Thanks for reviewing the code.
> On 2 Dec 2020, at 1:44 pm, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Rahul,
>
> On 26/11/2020 17:02, Rahul Singh wrote:
>> Linux SMMUv3 code implements the commands-queue insertion based on
>> atomic operations implemented in Linux. Atomic functions used by the
>> commands-queue insertion is not implemented in XEN therefore revert the
>> patch that implemented the commands-queue insertion based on atomic
>> operations.
>
> This commit message explains why we revert but not the consequence of the
> revert. Can outline if there are any and why they are fine?
Ok let me try to add more detail.
>
> I am also interested to have a list of *must* have for the driver to be out
> of the tech preview.
Ok let me add more informing in the commit message in next version of the patch.
Regards,
Rahul
>
> Cheers,
>
> --
> Julien Grall
|
