Re: [PATCH v4 04/23] libxl: add/recover 'rdm_policy' to/from PCI backend in xenstore

[Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>]

Hi, Paul!

On 11/24/20 10:01 AM, Paul Durrant wrote:
> From: Paul Durrant <pdurrant@xxxxxxxxxx>
>
> Other parameters, such as 'msitranslate' and 'permissive' are dealt with
> but 'rdm_policy' appears to be have been completely missed.
>
> Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>

Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>

Thank you,

Oleksandr

> ---
> Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> Cc: Wei Liu <wl@xxxxxxx>
> ---
>   tools/libs/light/libxl_pci.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
> index da01c77ba2..50c96cbfa6 100644
> --- a/tools/libs/light/libxl_pci.c
> +++ b/tools/libs/light/libxl_pci.c
> @@ -61,9 +61,9 @@ static void libxl_create_pci_backend_device(libxl__gc *gc,
>           flexarray_append_pair(back, GCSPRINTF("vdevfn-%d", num), 
> GCSPRINTF("%x", pci->vdevfn));
>       flexarray_append(back, GCSPRINTF("opts-%d", num));
>       flexarray_append(back,
> -              GCSPRINTF("msitranslate=%d,power_mgmt=%d,permissive=%d",
> -                             pci->msitranslate, pci->power_mgmt,
> -                             pci->permissive));
> +              
> GCSPRINTF("msitranslate=%d,power_mgmt=%d,permissive=%d,rdm_policy=%s",
> +                        pci->msitranslate, pci->power_mgmt,
> +                        pci->permissive, 
> libxl_rdm_reserve_policy_to_string(pci->rdm_policy)));
>       flexarray_append_pair(back, GCSPRINTF("state-%d", num), GCSPRINTF("%d", 
> XenbusStateInitialising));
>   }
>   
> @@ -2374,6 +2374,9 @@ static int libxl__device_pci_from_xs_be(libxl__gc *gc,
>               } else if (!strcmp(p, "permissive")) {
>                   p = strtok_r(NULL, ",=", &saveptr);
>                   pci->permissive = atoi(p);
> +            } else if (!strcmp(p, "rdm_policy")) {
> +                p = strtok_r(NULL, ",=", &saveptr);
> +                libxl_rdm_reserve_policy_from_string(p, &pci->rdm_policy);
>               }
>           } while ((p = strtok_r(NULL, ",=", &saveptr)) != NULL);
>       }