[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH RFC 1/6] xen/arm: mm: Remove special case for CPU0 in dump_hyp_walk()
On Sat, 28 Nov 2020, Julien Grall wrote: > On 19/11/2020 19:07, Julien Grall wrote: > > From: Stefano Stabellini <sstabellini@xxxxxxxxxx> > > > > There is no need to have a special case for CPU0 when converting the > > page-table virtual address into a physical address. The helper > > virt_to_maddr() is able to translate any address as long as the root > > page-tables is mapped in the virtual address. This is the case for all > > the CPUs at the moment. > > > > So use the same BUG_ON() regardless the CPU. > > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx> > > [julien: Rework the commit message] > > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx> > > > > --- > > > > I went back through the conversation in [1] regarding the issue when > > loading Xen below 2MB on Arm32. The example provided is wrong because to > > find the physical address, we need to add 'phys_offset', not substract. > > > > So I removed the comment regarding the code was buggy. > > > > [1] https://marc.info/?l=xen-devel&m=157081398022401 > > Stefano, can you confirm that you are happy with the new commit message? Yes, that's OK
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |