Re: [PATCH] tools/libs: Simplify internal *.pc files

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 25/11/2020 14:49, Andrew Cooper wrote:
> diff --git a/tools/Rules.mk b/tools/Rules.mk
> index f61da81f4a..5d92ff0699 100644
> --- a/tools/Rules.mk
> +++ b/tools/Rules.mk
> @@ -184,7 +184,7 @@ $(PKG_CONFIG_DIR)/%.pc: Makefile 
> $(XEN_ROOT)/tools/Rules.mk $(PKG_CONFIG_DIR)
>       echo "Description: $(PKG_CONFIG_DESC)"; \
>       echo "Version: $(PKG_CONFIG_VERSION)"; \
>       echo "Cflags: -I\$${includedir} $(CFLAGS_xeninclude)"; \
> -     echo "Libs: -L\$${libdir} $(PKG_CONFIG_USELIBS) -l$(PKG_CONFIG_LIB)"; \
> +     echo "Libs: -L\$${libdir} $(sort $(PKG_CONFIG_USELIBS)) 
> -l$(PKG_CONFIG_LIB)"; \
>       echo "Libs.private: $(PKG_CONFIG_LIBSPRIV)"; \
>       echo "Requires.private: $(PKG_CONFIG_REQPRIV)"; \
>       } > $@

Actually, it occurs to me that this would be better in libs.mk as

PKG_CONFIG_USELIBS := $(sort $(SHLIB_libxen$(LIBNAME)))

in case we gain any further uses of PKG_CONFIG_USELIBS

~Andrew