[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 3/6] xen/arm: setup: Call unregister_init_virtual_region() after the last init function
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 24 Nov 2020 13:25:18 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UVbzaMWJSPUqrJbAHs5E5esD8fonsBvUNk2PUepUqrg=; b=RXIrkgTFk3+BcuTNeQ2l+dZK2nGmAQ8MOf8VP96oI8DG3WKo2oKbxTNlBxjh30konw1mWAqe3YoPS851oUNR7jpMQaSvYolVn2maUn1GnD2gpi5faChuUB5NtKkYIqiez/U0OPRIQUIOtzMk6F5R5WlbnbAOWVD57dgmBbb/qNA1fyjiQz6MtBXy5uy3BzM3IPgZyPRP8X0l0A+wN5w1HrDX3F3v1lP/CkCg8D22PQakkFUQJ520o8C20C15Gt268JnBOrh9lJyNwLD8Dp8B/DvwA6jkrEFdIsFA6BJtk9cB1+ob9JKKGOH7pkkJbQPjLJKeAm2YB38jW112ZRashw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ka0P/TM/BYr+JOI9gvGLjMTtQ+hK8l3vWU/w1ttQ3YIRIhbnKosgV7eMNcpMRu2VwvblCY78DsUttkou5OGc06stpR1zQaUb/IvAx0hhUxoctBjycYLVc2TTVLsFddteO4bFCIdpphYvgkJwWagiGYCdXdKopNslYCiqLy4R3T9GvhZzqZeN3pFliXZZutp01kIuAUyuIM2+0EO2XKPSdflh0MSInUKai3AqPV3nsJh/VlWBUGq7VphVt8G2zYoG66stAIavgjNnFTqV0sjcAMXVDBp5srBbXsCzRpi1pVOoLcDfuoWkGTkZUclyORLDg3twMxNEa6HiLUHvvSr9pA==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 24 Nov 2020 13:25:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWvqdS2mJLaroJgEqXj0ki52YbT6nXTTEA
- Thread-topic: [PATCH RFC 3/6] xen/arm: setup: Call unregister_init_virtual_region() after the last init function
Hi Julien,
> On 19 Nov 2020, at 19:07, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> discard_init_modules() is an init function, if the path contains a
> BUG() or WARN() we still want to get the full stack trace.
>
> The init virtual region is now kept after the last init function has
> been called.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/setup.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 7fcff9af2a7e..2532ec973913 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -72,10 +72,11 @@ domid_t __read_mostly max_init_domid;
>
> static __used void init_done(void)
> {
> + discard_initial_modules();
> +
> /* Must be done past setting system_state. */
> unregister_init_virtual_region();
>
> - discard_initial_modules();
> free_init_memory();
> startup_cpu_idle_loop();
> }
> --
> 2.17.1
>
|
