Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 19/11/2020 09:00, Jan Beulich wrote:
> On 18.11.2020 16:35, Julien Grall wrote:
> > On 18/11/2020 15:16, Jan Beulich wrote:
> > > On 18.11.2020 16:02, Rahul Singh wrote:
> > > > Hello Jan,
> > > >
> > > > > On 17 Nov 2020, at 10:55 am, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> > > > >
> > > > > On 16.11.2020 13:25, Rahul Singh wrote:
> > > > > > NS16550 driver has PCI support that is under HAS_PCI flag. When HAS_PCI
> > > > > > is enabled for ARM, compilation error is observed for ARM architecture
> > > > > > because ARM platforms do not have full PCI support available.
> > > > > While you've extended the sentence, it remains unclear to me what
> > > > > compilation error it is that results here. I've requested such
> > > > > clarification for v2 already.
> > > > Compilation error is related to the code that refer to x86  functions 
> > > > (create_irq()..) and MSI implementation related error.
> > > > For more details please find the attached file for compilation error.
> > > The use of mmio_ro_ranges is almost quite possibly going to remain
> > > x86-specific, but then I guess this wants abstracting in a suitable
> > > way.
> > >
> > > The remaining look to all be MSI-related, so perhaps what you want
> > > to avoid is just that part rather than everything PCI-ish?
> > Not really (see more above).
> Did you really mean "above", not "below"? If so, I guess I need some
> clarification. If not, I suppose I've addressed your concern by the
> 2-patch series I've just sent.
This was meant to be "below".

Cheers,

--
Julien Grall