Re: [XEN PATCH] tools/xenstore: Log xenstored build ID on startup

[Bjoern Doebel <doebel@xxxxxxxxx>]

On 13.11.20 15:27, Jan Beulich wrote:
> On 13.11.2020 15:18, Bjoern Doebel wrote:
> > --- a/tools/xenstore/Makefile
> > +++ b/tools/xenstore/Makefile
> > @@ -66,6 +66,10 @@ $(XENSTORED_OBJS): CFLAGS += $(SYSTEMD_CFLAGS)
> >   xenstored: LDFLAGS += $(SYSTEMD_LIBS)
> >   endif
> >
> > +# xenstored: enforce creation of a buildID section and use a linker
> > +# script to add additional symbols around that section
> > +xenstored: LDFLAGS +=  -Wl,--build-id=sha1 -Wl,-T,buildid_symbols.ld
> Since in the hypervisor build we're careful to not use --build-id
> when the linker doesn't support it, I suppose the same care needs
> applying here. See the setting of build_id_linker in ./Config.mk.
Ok, I will make this conditional on the setting of $(build_id_linker).

> Jan
Bjoern




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879