Re: [PATCH v4 3/3] xen/x86: issue pci_serr error message via NMI continuation

[Jürgen Groß <jgross@xxxxxxxx>]

On 12.11.20 10:29, Jan Beulich wrote:
> On 09.11.2020 10:50, Juergen Gross wrote:
> > Instead of using a softirq pci_serr_error() can use NMI continuation
> > for issuing an error message.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> with one minor change to be considered:
>
> > @@ -1808,6 +1816,9 @@ bool nmi_check_continuation(void)
> >       if ( nmi_oprofile_send_virq() )
> >           ret = true;
> >   
> > +    if ( pci_serr_nmicont() )
> > +        ret = true;
> > +
> >       return ret;
> >   }
> As the likely more important part, wouldn't it be better to insert
> this ahead of the oprofile check?
Fine with me.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature
Description: OpenPGP digital signature