Re: [RFC PATCH 4/6] xen/arm64: Port Linux LL/SC and LSE atomics helpers to Xen

[Julien Grall <julien@xxxxxxx>]

On 06/11/2020 10:55, Ash Wilding wrote:
> Hi,
Hi Ash,

First of all, thank you for taking a stab at adding LSE support in Xen!

> In retrospect I should have put an intermediate patch between #3 and #4,
> deleting the existing headers. This would have made the patch diff for
> #4 and #5 much easier to read seeing as they are copying the Linux
> versions wholesale into Xen.
While I agree it would help the review, it would break Xen 
bisectability. Although, it should be feasible to fold all the patches 
in one on committing.
If you are going to split the patches then I would suggest the following 
split:
  1) Remove Xen atomic headers
  2) Add a verbatim copy of the Linux headers
  3) Modify them for Xen

With this approach, we can focus on just Xen changes rather than having 
to review the Linux code as well.
> I'll do that for V1 when we get there, but for now to aid in readability
> I've pasted the complete header files below. While doing this I also
> spent some time last night tidying up them up to be in line with the Xen
> coding style.
We usually keep Linux coding style when a file mainly contains Linux 
code. This is making easier to port future fixes from Linux to Xen.
Regarding the review, I have quite a bit of backlog for Xen at the 
moment. I will try to review the series in the next couple of weeks.
I hope that's fine with you.

Cheers,

--
Julien Grall