[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg
- To: Eduardo Habkost <ehabkost@xxxxxxxxxx>
- From: Marc-André Lureau <marcandre.lureau@xxxxxxxxx>
- Date: Fri, 30 Oct 2020 11:34:09 +0400
- Cc: QEMU <qemu-devel@xxxxxxxxxx>, Matthew Rosato <mjrosato@xxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "open list:Block layer core" <qemu-block@xxxxxxxxxx>, Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, Halil Pasic <pasic@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, "Daniel P. Berrange" <berrange@xxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Qemu-s390x list <qemu-s390x@xxxxxxxxxx>, Max Reitz <mreitz@xxxxxxxxxx>, Igor Mammedov <imammedo@xxxxxxxxxx>
- Delivery-date: Fri, 30 Oct 2020 07:34:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Make the code more generic and not specific to TYPE_DEVICE.
Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx>
Nice cleanup!, but fails to build atm
../hw/block/xen-block.c:403:9: error: ‘dev’ undeclared (first use in this function); did you mean ‘vdev’?
403 | if (dev->realized) {
That seems to be the only issue though, so with that fixed:
-- Marc-André Lureau
|
