[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: inconsistent pfn type checking in process_page_data

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Wed, 28 Oct 2020 11:54:33 +0100
Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 28 Oct 2020 10:54:50 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Am Wed, 28 Oct 2020 10:39:55 +0000
schrieb Andrew Cooper <andrew.cooper3@xxxxxxxxxx>:

> I would however recommend against the name is_data_page_type() because
> then the predicate is ambiguous with "== NOTAB".

Why is it ambiguous? It is not obvious to me.

page_type_has_stream_data() is certainly fine as a name.


Olaf

Attachment: pgp3zcrAfPOsR.pgp
Description: Digitale Signatur von OpenPGP

References:
- inconsistent pfn type checking in process_page_data
  - From: Olaf Hering
- Re: inconsistent pfn type checking in process_page_data
  - From: Andrew Cooper
- Re: inconsistent pfn type checking in process_page_data
  - From: Olaf Hering
- Re: inconsistent pfn type checking in process_page_data
  - From: Andrew Cooper

Prev by Date: Re: [PATCH v1 1/4] xen/ns16550: solve compilation error on ARM with CONFIG_HAS_PCI enabled.
Next by Date: [xen-4.12-testing test] 156263: regressions - FAIL
Previous by thread: Re: inconsistent pfn type checking in process_page_data
Next by thread: [xen-unstable test] 156254: tolerable FAIL
Index(es):
- Date
- Thread

Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.