[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Ocfs2-devel] [RFC] treewide: cleanup unreachable breaks
- To: trix@xxxxxxxxxx
- From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
- Date: Sun, 18 Oct 2020 19:59:43 +0100
- Cc: linux-kernel@xxxxxxxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx, clang-built-linux@xxxxxxxxxxxxxxxx, linux-iio@xxxxxxxxxxxxxxx, nouveau@xxxxxxxxxxxxxxxxxxxxx, storagedev@xxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, keyrings@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, ath10k@xxxxxxxxxxxxxxxxxxx, MPT-FusionLinux.pdl@xxxxxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, usb-storage@xxxxxxxxxxxxxxxxxxxxxxxx, linux-watchdog@xxxxxxxxxxxxxxx, devel@xxxxxxxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-nvdimm@xxxxxxxxxxxx, amd-gfx@xxxxxxxxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, intel-wired-lan@xxxxxxxxxxxxxxxx, industrypack-devel@xxxxxxxxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, spice-devel@xxxxxxxxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-nfc@xxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-gpio@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, openipmi-developer@xxxxxxxxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, linux-integrity@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-edac@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, patches@xxxxxxxxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, linux-power@xxxxxxxxxxxxxxxxx
- Delivery-date: Sun, 18 Oct 2020 19:00:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Sat, Oct 17, 2020 at 09:09:28AM -0700, trix@xxxxxxxxxx wrote:
> clang has a number of useful, new warnings see
> https://urldefense.com/v3/__https://clang.llvm.org/docs/DiagnosticsReference.html__;!!GqivPVa7Brio!Krxz78O3RKcB9JBMVo_F98FupVhj_jxX60ddN6tKGEbv_cnooXc1nnBmchm-e_O9ieGnyQ$
>
Please get your IT department to remove that stupidity. If you can't,
please send email from a non-Red Hat email address.
I don't understand why this is a useful warning to fix. What actual
problem is caused by the code below?
> return and break
>
> switch (c->x86_vendor) {
> case X86_VENDOR_INTEL:
> intel_p5_mcheck_init(c);
> return 1;
> - break;
Sure, it's unnecessary, but it's not masking a bug. It's not unclear.
Why do we want to enable this warning?
|
