[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/4] x86/shim: don't permit HVM and PV_SHIM_EXCLUSIVE at the same time


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Thu, 8 Oct 2020 16:52:29 +0200
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
  • Delivery-date: Thu, 08 Oct 2020 14:52:52 +0000
  • Ironport-sdr: +W/Mo867VPZVHBh+yRvNqntNMjCYjoK82wbO6EnPy1r9iDbQjHOqZwStoUuut2tSuXsu49UZym zpxkgHj3sdyloWJXGYenlv2LKSw4hOAnfJPNdj3mca1dvltEjMX5XatUuRWm6TGUvlElSYZsUX sv+d6Znx+jNmQYs+gY4+GWBBsKTDkDOfzgmmTkniZJh0uUyV/5uiMMf8QQY8M85Q4rfw7UnIL9 20ss9h9I32YQYXbdS+wFwuQQ64k+pIIdXz7cpLEFTPGg6rHfNvFXG3/1WGsV2ZMlt5jLGfS78q N3E=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Sep 16, 2020 at 03:08:00PM +0200, Jan Beulich wrote:
> This combination doesn't really make sense (and there likely are more);
> in particular even if the code built with both options set, HVM guests
> wouldn't work (and I think one wouldn't be able to create one in the
> first place). The alternative here would be some presumably intrusive
> #ifdef-ary to get this combination to actually build (but still not
> work) again.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

I can see the desire for being able to remove code, and the point
Andrew made about one option not making another disappear in a
completely different menu section.

Yet I don't see how to converge the two together, unless we completely
change our menu layouts, and even then I'm not sure I see how we could
structure this. Hence:

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.