|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [OSSTEST PATCH 45/82] sg-run-job: Detect improper use of @ iffail with run-ts
From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Only per-host-ts understands this. This is a bit of a bear trap, so
arrange to bail rather than putting strange step status values with
`@' at the front in the database...
Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
sg-run-job | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sg-run-job b/sg-run-job
index a074cd42..067b28db 100755
--- a/sg-run-job
+++ b/sg-run-job
@@ -317,6 +317,9 @@ proc iffail-check {iffail okexpr iffail_status_var} {
if {![regsub {^!} $iffail {} iffail_status]} {
if {![uplevel 1 [list expr $okexpr]]} { return 0 }
}
+ if {[regexp {^@} $iffail]} {
+ error "internal error - @ only valid for iffail with per-host-ts"
+ }
return 1
}
--
2.20.1
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |