Re: [PATCH V1 09/16] arm/ioreq: Introduce arch specific bits for IOREQ/DM features

[Oleksandr <olekstysh@xxxxxxxxx>]

On 25.09.20 09:51, Jan Beulich wrote:

Hi Jan

> On 24.09.2020 20:02, Oleksandr wrote:
> > On 24.09.20 19:02, Oleksandr wrote:
> > Julien, I noticed that three fields mmio* are not used within current
> > series on Arm. Do we expect them to be used later on?
> > I would rather not add fields which are not used. We could add them when
> > needed.
> >
> > Would be the following acceptable?
> > 1. Both fields "io_completion" and "io_req" (which seems to be the only
> > fields used in common/ioreq.c) are moved to common struct vcpu as part
> > of struct vcpu_io,
> >       enum hvm_io_completion is also moved (and renamed).
> > 2. We remove everything related to hvm_vcpu* from the Arm header.
> > 3. x86's struct hvm_vcpu_io stays as it is (but without two fields
> > "io_completion" and "io_req").
> >       I think, this way we separate a common part and reduce Xen changes
> > (which are getting bigger).
> If this works, it would be my preference too.
Thanks. I will wait for Julien's input on that and if he doesn't have 
any objections I will go this direction.

--
Regards,

Oleksandr Tyshchenko