Re: [PATCH v4 3/4] xen: Remove mfn_to_gmfn macro

[Julien Grall <julien@xxxxxxx>]

On 21/09/2020 21:34, Andrew Cooper wrote:
> On 21/09/2020 19:02, Julien Grall wrote:
> > From: Julien Grall <julien.grall@xxxxxxx>
> >
> > On x86, mfn_to_gmfn can be replaced with mfn_to_gfn. On Arm, there are
> > no more call to mfn_to_gmfn, so the helper can be dropped.
> The previous patch dropped the mfn_to_gmfn() call from the domain shared
> info path, but without a hunk adjusting the innards of
> memory_exchange(), this is going to break the x86 build.
Urgh, I thought I build test it the code. I will fix it.

> > At the same time rework a comment in Arm code that does not make sense.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> To save a round trip, Acked-by: Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx> with the appropriate hunk to memory_exchange().
>
> Alternatively, it might make sense to fold the adjustment into patch 1
> which is perhaps more obvious, given the insertion of an is_pv_domain()
> check.
I will add in this patch unless someone else also prefer that the change 
is added in patch #1.
Cheers,

--
Julien Grall