Re: [PATCH v5 5/5] efi: Do not use command line if unified config is included

[Jan Beulich <jbeulich@xxxxxxxx>]

On 17.09.2020 17:40, Trammell Hudson wrote:
> @@ -1155,8 +1184,10 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE 
> *SystemTable)
>          PrintErrMesg(L"No Loaded Image Protocol", status);
>  
>      efi_arch_load_addr_check(loaded_image);
> +    secure = efi_secure_boot();
>  
> -    if ( use_cfg_file )
> +    if ( use_cfg_file &&
> +         !read_section(loaded_image, ".config", &cfg, NULL))
>      {
>          UINTN offset = 0;

I continue to think that it's wrong to ignore the command line
altogether. And this isn't just for the Dom0 kernel part when
there's no .kernel section, but also because there may be
firmware workarounds that the user needs to be able to make use
of in order for the binary to work on certain hardware.

Jan